Items on crafted bases missing from Data/Bases (e.g. Runemastered Long Quarterstaff) are silently dropped

未關閉
#2,582 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

@vaisest 已經在處理了。

開始於 2026年11月5日。

  • #2583 來自 @vaisest —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
lua
領域
backend

研究方向

Start by comparing the crafted base names in Data/VerisiumCrafts.lua with entries in Data/Bases/*.lua, then read the item loading path in Classes/ItemsTab.lua around the cited line. Check how repeated base keys with multiple implicits are handled, using Runemastered Runic Fork as an example. Done means the listed bases are recognized and their intended implicits survive loading; verify with the custom Pillar of the Caged God item described in the issue.

由索引模型根據 Issue 內容生成。

描述

Check version
  • I'm running the latest version of Path of Building (dev at bb52d6b, 2026-10-01)
Check for duplicates
  • I've checked for duplicate open and closed issues (searched "Runemastered", "Long Quarterstaff", "missing base runeforged")
Check for support
  • Crafted Verisium bases are supported (Data/VerisiumCrafts.lua, itemLib.addRuneforgingBaseVariants)
What platform are you running Path of Building on?

macOS (headless, from the source); the cause is in the data, so it should be the same on every platform.

What is the behaviour in-game?

A character has a Pillar of the Caged God on a Runemastered Long Quarterstaff equipped in weapon set 1. poe.ninja shows it on the character.

What is the behaviour in Path of Building?

The weapon is gone: the build opens with both weapon slots empty, and the main skill (Storm Wave, a Quarterstaff skill) shows 0 DPS. The PoB code that poe.ninja exports for the character already has no weapon item, probably because the exporter also uses PoB's data.

Cause. Data/VerisiumCrafts.lua lists crafted bases that have no entry in Data/Bases/*.lua. When an item's base is not in data.itemBases, ItemsTab:Load keeps it only if item.base then (Classes/ItemsTab.lua, around line 1275), so the item is dropped without any message.

These are the crafted bases named in VerisiumCrafts.lua but missing from Data/Bases/ on the current dev:

Runeforged Crescent Quarterstaff   <- Crescent Quarterstaff
Runeforged Gothic Quarterstaff     <- Gothic Quarterstaff
Runeforged Long Quarterstaff       <- Long Quarterstaff
Runeforged Steelpoint Quarterstaff <- Steelpoint Quarterstaff
Runeforged Wrapped Quarterstaff    <- Wrapped Quarterstaff
Runemastered Gothic Quarterstaff   <- Runeforged Gothic Quarterstaff
Runemastered Long Quarterstaff     <- Runeforged Long Quarterstaff
The Triskelion Reforged            <- Shattered Triskelion

Every Runeforged quarterstaff is missing. The only crafted quarterstaff in Data/Bases/staff.lua is Runemastered Warding Quarterstaff.

A related data issue: when a crafted base can have several implicits, Data/Bases/*.lua defines the same key once per implicit. For example, itemBases["Runemastered Runic Fork"] appears three times: Spell projectiles, Mana Regeneration and Runic Ward. Only the last definition survives in data.itemBases, so the base's own implicit is always the Runic Ward one.

How to reproduce the issue
  1. Items tab → "Create custom", paste:
    Rarity: Unique
    Pillar of the Caged God
    Runemastered Long Quarterstaff
    Implicits: 1
    16% increased Melee Strike Range with this weapon
    10% increased Weapon Damage per 10 Strength
    
    PoB does not recognise the base (the parsed item has no base). With Long Quarterstaff as the base, the same item works.
  2. Or load any build XML with that item in Weapon 1: the slot comes back empty.
PoB for PoE2 build code

Not attached: the code exported by poe.ninja already lacks the weapon. The item above reproduces it.

主要語言
Lua
星號
1.9k
分支
469
PR 合併指標
30 天內沒有已合併 PR

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

PathOfBuildingCommunity/PathOfBuilding-PoE2 的其他 Issue

查看 PathOfBuildingCommunity/PathOfBuilding-PoE2 的全部 Issue

相似的 Issue

更多 Lua Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。