Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Drillneck: "for each time they have Pierced" modifiers are not parsed

Open Beginner friendly
  • Is something wrong?
#2,560 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
80/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
lua
Domain
data

Research direction

Add the uncontracted key next to the existing contracted entry at src/Modules/ModParser.lua:1681, using the same tag { type = "PerStat", stat = "PiercedCount" }; the game-data strings UniqueProjectileIncreasedDamagePerPierce1 and UniqueProjectileIncreasedCriticalHitChancePerPierce1 in src/Data/ModItemExclusive.lua show the exact wording to match. Then regenerate src/Data/ModCache.lua so the leftover " for each time they have Pierced " suffix disappears from the Drillneck lines. Verify by equipping Drillneck, setting "# of times Skill has Pierced" in Configuration, and confirming DPS and crit chance change; the related "Attack Projectiles Return if they Pierced" line at ModCache.lua:6616 is out of scope.

Written by the indexing model from the issue text.

Description

Drillneck (Penetrating Quiver) has two per-pierce modifiers:

Projectiles deal (42-64)% increased Damage with Hits for each time they have Pierced
Projectiles have (42-64)% increased Critical Hit chance for each time they have Pierced

PoB parses the increase but not the condition, so part of each line is left unparsed and neither line is applied, whatever the pierce count is. The generated cache records the remainder:

src/Data/ModCache.lua:8996
c["Projectiles deal 64% increased Damage with Hits for each time they have Pierced"]={{[1]={flags=1024,keywordFlags=262144,name="Damage",type="INC",value=64}},"   for each time they have Pierced "}

The game-data wording is "they have Pierced" (src/Data/ModItemExclusive.lua, UniqueProjectileIncreasedDamagePerPierce1 and UniqueProjectileIncreasedCriticalHitChancePerPierce1). ModParser.lua only has the contracted form:

-- src/Modules/ModParser.lua:1681 (dev bb52d6b)
["for each time they've pierced"] = { tag = { type = "PerStat", stat = "PiercedCount" } },
Proposed fix

Add the uncontracted wording next to it, with the same tag, then regenerate ModCache.lua:

["for each time they have pierced"] = { tag = { type = "PerStat", stat = "PiercedCount" } },
Repro
  1. Equip Drillneck with a projectile skill.
  2. In Configuration, set "# of times Skill has Pierced" to 1 or 2.
  3. Damage and crit chance do not change.
Measured effect

With the two lines reworded to "they've Pierced" (which PoB parses), a Frostbolt build against the boss preset:

# of times Skill has Pierced Frostbolt DPS Crit chance
0 3,572 11.4%
1 12,660 39.1%
2 27,308 66.8%

With the item's own wording, every pierce count reads as the first row.

Not in this report

"Attack Projectiles Return if they Pierced at least (2-4) times" is also unparsed (ModCache.lua:6616). Return is a separate mechanic, so it would be a separate report.

Dominant language
Lua
Stars
1.9k
Forks
455
Avg merge
6d 6h
Merged PRs (30d)
25

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PathOfBuildingCommunity/PathOfBuilding-PoE2

All issues in PathOfBuildingCommunity/PathOfBuilding-PoE2

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.