Require dplyr 1.1.1 for the join relationship argument
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- r
- Domain
- build-system
Research direction
Start in DESCRIPTION: bump the dplyr dependency to >= 1.1.1, then confirm the two call sites named in the issue (R/add_actor_partner_columns.R around lines 153-157 and R/temporary_dyad_occasion_completion.R around lines 53-58) actually pass relationship = "many-to-many". Run the sample dyadMLM::prepare_dyad_data(...) snippet from the issue plus one intensive-longitudinal preparation in a library pinned to dplyr 1.1.1, and finish with the usual R CMD check. Done means the DESCRIPTION line is raised, both preparations succeed, and checks pass with no new test job.
Written by the indexing model from the issue text.
Description
Problem
DESCRIPTION allows dplyr 1.1.0, but two preparation joins use relationship = "many-to-many":
dplyr 1.1.1 introduced this argument; 1.1.0 rejects it. Preparation can therefore fail with an allowed version.
Fix
- Require
dplyr (>= 1.1.1)inDESCRIPTION. - In a separate R library with dplyr 1.1.1, check one basic APIM preparation and one intensive longitudinal preparation.
- Run the usual package checks. No new permanent test job for older dplyr versions is needed.
Basic APIM check:
dat <- data.frame(dyad = c(1, 1, 2, 2), member = c(1, 2, 1, 2), x = 1:4)
dyadMLM::prepare_dyad_data(dat, dyad, member, predictors = x, seed = 1)
Source checked at c92eb46. The dplyr release notes and code confirm the requirement; preparation checks with dplyr 1.1.1 remain to be run.
Related: #33.
- Dominant language
- R
- Stars
- 1
- Forks
- 2
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Pascal-Kueng/dyadMLM
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Pascal-Kueng/dyadMLM#92 ·
Maintainers usually reply within 1 day
-
Warn when lag-1 columns are entirely missingPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Pascal-Kueng/dyadMLM#83 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Pascal-Kueng/dyadMLM#71 · 3 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Pascal-Kueng/dyadMLM#70 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Pascal-Kueng/dyadMLM#69 · 1 comment ·
Maintainers usually reply within 1 day
All issues in Pascal-Kueng/dyadMLM
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
AlexsLemonade/scpca-nf#1357 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
REditorSupport/vscode-R#1883 ·
Maintainers usually reply within 1 day
-
Error out post processing step if there are multiple folders in /exec with the same index numberOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100