Warn when lag-1 columns are entirely missing
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
Research direction
Start from prepare_dyad_data(), the function named in the issue, and locate where lag-1 columns are generated by matching on exactly time - 1; that is where the new check belongs. Add a warning (wording supplied in the issue) emitted when a generated lag-1 column is NA on every row, plus one test reproducing a non-consecutive time scale (e.g. 0, 6, 12) in the package's test suite. Done when the warning fires for all-missing lag columns, stays silent for healthy data, and the new test passes alongside existing ones.
Written by the indexing model from the issue text.
Description
prepare_dyad_data() matches lags at exactly time - 1. Validation only checks that time is whole-numbered, so time coded in its natural unit silently produces lag columns that are NA on every row:
- months: 0, 6, 12
- years with two-year waves: 2008, 2010, 2012
Models with lags then drop all rows, without any hint why.
Proposal: warn when a generated lag-1 column is NA on every row, e.g.
All lag-1 values of
healthare missing. Lags match observations at exactlytime - 1; iftimecounts months or years with steps larger than 1, recode it as a consecutive occasion index (1, 2, 3, …).
Plus one test. Independent of the singleton work in dev/partner-exists-spec.md.
- Dominant language
- R
- Stars
- 1
- Forks
- 2
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 23
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Pascal-Kueng/dyadMLM
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Pascal-Kueng/dyadMLM#92 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Pascal-Kueng/dyadMLM#71 · 3 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Pascal-Kueng/dyadMLM#70 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Pascal-Kueng/dyadMLM#69 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Pascal-Kueng/dyadMLM#68 ·
Maintainers usually reply within 1 day
All issues in Pascal-Kueng/dyadMLM
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Tests error instead of skipping when optional packages (ecmwfr, jsonvalidate) or BETY database are unavailablePossibly taken @madhavzanwar claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PecanProject/pecan#4179 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Huber-group-EMBL/Rarr#261 ·
Maintainers usually reply within 1 day