Extend roadtypes / tramtypes examples and provide tests

Open
#47 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python

Research direction

Start by reviewing examples/roadtype_and_tramtype/ and examples/road_vehicle, comparing them with the railtype example and the roadtype/tramtype specification. Done means accurate, broader roadtype and tramtype examples with matching road vehicles and a tram, corrected sprites, and tests covering both types.

Written by the indexing model from the issue text.

Description

Current

examples/roadtype_and_tramtype/ contains rudimentary examples for multiple roadtypes and a tramtype. These were copy-paste-edit of the railtype example, and contain railtype gui icons etc.

examples/road_vehicle includes one road vehicle compatible with some of the example roadtypes. It would be helpful to have more example road vehicles, covering the range of example roadtypes / tramtypes.

There are no tests for roadtypes / tramtypes.

Desired

  • ensure the roadtype / tramtype examples are accurate, and provide fair coverage of the spec
  • extend the example road vehicles and also provide a tram
  • swap any relevant railtype sprites to roadtype / tramtype sprites
  • provide test(s) for roadtypes and tramtypes
Dominant language
Python
Stars
61
Forks
47
Avg merge
8d 14h
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenTTD/nml

All issues in OpenTTD/nml

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.