No error when tram_type property is set without a tram typetable
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
No file or test is named in the issue. Start by tracing validation for tram_type, tramtypetable, and ROADVEH_FLAG_TRAM, then reproduce the missing-property cases; done means NML reports an error for the stated scenario and clarifies any related tram consistency checks.
Written by the indexing model from the issue text.
Description
If a tram is created with no tram_type property, OpenTTD will use the default ELRL. But if a tram_type property is set (even to ELRL) without a tramtypetable, OpenTTD does not default to ELRL
NML should throw an error in this scenario.
Possibly also around some similar "You've set tram_type but no ROADVEH_FLAG_TRAM" edge cases (and vice versa), if required, I generally found it a bit confusing to create a tram with no feedback when I was missing properties and multiple are required
- Dominant language
- Python
- Stars
- 61
- Forks
- 47
- Avg merge
- 8d 14h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenTTD/nml
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Bug(?): Re-definition of alternative sprites is not treated as an error but has no productive useOpen
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
15-minutes 5-minutes algorithm any-language beginner-friendly c cpp csharp easy go good first issue hacktoberfest help wanted java javascript kotlin python rust swift typescript
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Huerte/algo-solutions-python#254 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
MichaelYcJo/SpecSeal#1543 ·
-
size/s
Difficulty 1/5 Under an hour Newbie friendliness 90/100
sipyourdrink-ltd/bernstein#7179 ·
Maintainers usually reply within 1 day
-
good first issue help wanted python up-for-grabs
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
andrewsiah/agentswarm-data-tasks#309 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day