Add AIR_DRAG_DEFAULT and AIR_DRAG_NONE constants

Open
#219 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
compilers

Research direction

Start by tracing the air_drag_coefficient property and its unit conversion in NML. Check how integer values 0 and 1 are currently handled, then identify the relevant tests or test entry point. Done means exposing AIR_DRAG_DEFAULT and AIR_DRAG_NONE constants so users no longer need the 1/255 workaround while preserving the distinct default behavior.

Written by the indexing model from the issue text.

Description

The air_drag_coefficient property of trains and road vehicles has some magic values:

  • Integer 0: use some default max_speed-dependent value.
  • Integer 1: apply no air drag.

Currently NML applies unit conversion to this value, so to get no air drag you have to set "1/255", while "0" does something entirely different.

Dominant language
Python
Stars
61
Forks
47
Avg merge
8d 14h
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenTTD/nml

All issues in OpenTTD/nml

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.