[BUG][JAVA][SPRING] Collection request-body validation skipped with useSpringBuiltInValidation=true after 7.25.0

Open
#25,734 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@Inf1mum is already working on this.

Since Nov 18, 2026.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java, spring
Domain
api, backend

Research direction

Start with modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache and compare the v7.25.0 and v7.26.0 versions linked in the issue. Then inspect the Spring generator tests that cover request body validation and reproduce the described collection request with useSpringBuiltInValidation=true. Done means the generated interface preserves validation and the invalid item returns HTTP 400 before the controller runs; coordinate with the already open PR #25741.

Written by the indexing model from the issue text.

Description

Issue: Bug

Description

After upgrading openapi-generator-maven-plugin from 7.25.0 to 7.27.0, an existing Spring MVC endpoint accepting a list of DTOs accepts invalid collection elements instead of returning HTTP 400.

We use useSpringBuiltInValidation=true, so the generated interface does not have class-level @Validated.

The generated request parameter changes from:

@Valid @RequestBody List<@Valid Item> items

to:

@RequestBody List<@Valid Item> items

The DTO constraints are unchanged.

Expected: Invalid collection elements are rejected with HTTP 400 before the controller implementation executes.

Actual: Invalid collection elements reach the controller, and the endpoint returns HTTP 204.

With 7.25.0, the request is rejected with HandlerMethodValidationException.

Versions

  • Previously working: 7.25.0
  • Runtime failure observed: 7.27.0
  • The relevant template change is already present in 7.26.0, but that version has not been separately runtime-tested.
  • Spring Boot: 3.5.16
  • Java: 21

Template comparison:

https://github.com/OpenAPITools/openapi-generator/blob/v7.25.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

https://github.com/OpenAPITools/openapi-generator/blob/v7.26.0/modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache

Generator configuration

<generatorName>spring</generatorName>
<library>spring-boot</library>
<generateApis>true</generateApis>
<configOptions>
  <useSpringBoot3>true</useSpringBoot3>
  <useJakartaEe>true</useJakartaEe>
  <interfaceOnly>true</interfaceOnly>
  <skipDefaultInterface>true</skipDefaultInterface>
  <useResponseEntity>false</useResponseEntity>
  <useSpringBuiltInValidation>true</useSpringBuiltInValidation>
</configOptions>

Illustrative OpenAPI specification

The regression was observed in an existing application. This generic specification illustrates the affected request shape; this standalone example has not yet been executed.

openapi: 3.0.3
info:
  title: Collection validation example
  version: 1.0.0
paths:
  /items:
    post:
      operationId: updateItems
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                $ref: '#/components/schemas/Item'
      responses:
        '204':
          description: Accepted
components:
  schemas:
    Item:
      type: object
      properties:
        name:
          type: string
          maxLength: 3

Implement the generated interface in a @RestController, without adding class-level @Validated, and submit:

POST /items
Content-Type: application/json

[{"name":"too long"}]

The invalid name should cause HTTP 400 rather than reaching the controller.

Related upstream change

This appears related to the removal of container-level @Valid in:

https://github.com/OpenAPITools/openapi-generator/pull/24176

The author's runtime verification uses a controller annotated with class-level @Validated:

https://github.com/OpenAPITools/openapi-generator/pull/24176#issuecomment-4859610681

However, useSpringBuiltInValidation=true intentionally suppresses that annotation and uses Spring MVC's built-in validation. Therefore, that verification does not cover this configuration.

Could the generator preserve collection request-body validation with useSpringBuiltInValidation=true, or document a supported migration for this configuration?

Dominant language
Java
Stars
26.9k
Forks
7.8k
Avg merge
2d 23m
Merged PRs (30d)
177

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenAPITools/openapi-generator

All issues in OpenAPITools/openapi-generator

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.