[BUG][JAVA][SPRING] Collection request-body validation skipped with useSpringBuiltInValidation=true after 7.25.0
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with modules/openapi-generator/src/main/resources/JavaSpring/bodyParams.mustache and compare the v7.25.0 and v7.26.0 versions linked in the issue. Then inspect the Spring generator tests that cover request body validation and reproduce the described collection request with useSpringBuiltInValidation=true. Done means the generated interface preserves validation and the invalid item returns HTTP 400 before the controller runs; coordinate with the already open PR #25741.
Written by the indexing model from the issue text.
Description
Description
After upgrading openapi-generator-maven-plugin from 7.25.0 to 7.27.0, an existing Spring MVC endpoint accepting a list of DTOs accepts invalid collection elements instead of returning HTTP 400.
We use useSpringBuiltInValidation=true, so the generated interface does not have class-level @Validated.
The generated request parameter changes from:
@Valid @RequestBody List<@Valid Item> items
to:
@RequestBody List<@Valid Item> items
The DTO constraints are unchanged.
Expected: Invalid collection elements are rejected with HTTP 400 before the controller implementation executes.
Actual: Invalid collection elements reach the controller, and the endpoint returns HTTP 204.
With 7.25.0, the request is rejected with HandlerMethodValidationException.
Versions
- Previously working: 7.25.0
- Runtime failure observed: 7.27.0
- The relevant template change is already present in 7.26.0, but that version has not been separately runtime-tested.
- Spring Boot: 3.5.16
- Java: 21
Template comparison:
Generator configuration
<generatorName>spring</generatorName>
<library>spring-boot</library>
<generateApis>true</generateApis>
<configOptions>
<useSpringBoot3>true</useSpringBoot3>
<useJakartaEe>true</useJakartaEe>
<interfaceOnly>true</interfaceOnly>
<skipDefaultInterface>true</skipDefaultInterface>
<useResponseEntity>false</useResponseEntity>
<useSpringBuiltInValidation>true</useSpringBuiltInValidation>
</configOptions>
Illustrative OpenAPI specification
The regression was observed in an existing application. This generic specification illustrates the affected request shape; this standalone example has not yet been executed.
openapi: 3.0.3
info:
title: Collection validation example
version: 1.0.0
paths:
/items:
post:
operationId: updateItems
requestBody:
required: true
content:
application/json:
schema:
type: array
items:
$ref: '#/components/schemas/Item'
responses:
'204':
description: Accepted
components:
schemas:
Item:
type: object
properties:
name:
type: string
maxLength: 3
Implement the generated interface in a @RestController, without adding class-level @Validated, and submit:
POST /items
Content-Type: application/json
[{"name":"too long"}]
The invalid name should cause HTTP 400 rather than reaching the controller.
Related upstream change
This appears related to the removal of container-level @Valid in:
https://github.com/OpenAPITools/openapi-generator/pull/24176
The author's runtime verification uses a controller annotated with class-level @Validated:
https://github.com/OpenAPITools/openapi-generator/pull/24176#issuecomment-4859610681
However, useSpringBuiltInValidation=true intentionally suppresses that annotation and uses Spring MVC's built-in validation. Therefore, that verification does not cover this configuration.
Could the generator preserve collection request-body validation with useSpringBuiltInValidation=true, or document a supported migration for this configuration?
- Dominant language
- Java
- Stars
- 26.9k
- Forks
- 7.8k
- Avg merge
- 2d 23m
- Merged PRs (30d)
- 177
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenAPITools/openapi-generator
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OpenAPITools/openapi-generator#25768 ·
Maintainers usually reply within 1 day
-
Enhancement: Feature
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OpenAPITools/openapi-generator#25753 ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] A non-String value in a pattern-constrained attribute raises NoMethodErrorPossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenAPITools/openapi-generator#25724 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] Response#to_hash is advertised and raises when the data is an ArrayPossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenAPITools/openapi-generator#25723 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG][RUBY-NEXTGEN] A JSON string response raises ApiError because the body is parsed twicePossibly taken @Inf1mum claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenAPITools/openapi-generator#25719 · 1 comment ·
Maintainers usually reply within 1 day
All issues in OpenAPITools/openapi-generator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
eclipse-tradista/tradista#371 ·
Maintainers usually reply within 1 day
-
critical
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mars-sim/mars-sim#2199 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
projeto-ong-amar/projeto-ong-amar-backend#26 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
primefaces/primefaces#15568 ·
Maintainers usually reply within 1 day
-
崩溃日志只按 CRLF 分行Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PCL-Community/PCL-CE#3872 ·
Maintainers usually reply within 1 day