Refactor phasor dynamics bus and system classes

Open
#604 0 comments 2 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@pelesh is already working on this.

Since Oct 5, 2026.

Assessment

This issue has not been assessed yet.

Description

enhancement
Summary

There are a few features that need to be implemented in order to enable PhasorDynamics::SystemModel partitioning and subsequently implementation of an interface to partitioned solvers. See #143 and #323, as well as #463.

@superwhiskers @alexander-novo @nkoukpaizan @abdourahmanbarry @lukelowry @Steven-Roberts

Rationale

Bus (or rather BusBase class) and SystemSolver class need to provide features to support partitioning a system into subsystems. Enabling hierarchical modeling would allow applying different methods from a multimethod solver to different system partitions.

Description

Some thoughts how to proceed:

  • Consider adding feature to the SystemModel to take other SystemModel instances as components.
  • Consider enabling SystemModel to identify buses that are used for external connections so they can be used as components in a larger system.
  • Add subsystem specification to JSON input file format.
  • Remove pointers to buses from component model constructors. Set connection to buses in a similar manner as connections to signal nodes.
  • Consider adding signal-connected buses as proposed in #602.
Additional information

This issue is to discuss prep work needed for partitioned models. PR #573 illustrates well what support is needed for hierarchical modeling.

Dominant language
C++
Stars
27
Forks
11
Avg merge
2d 21h
Merged PRs (30d)
15

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ORNL/GridKit

All issues in ORNL/GridKit

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.