Extract CommonMath functions
Maintainers usually reply within 1 day
@amandeep25100-a11y is already working on this.
Since Nov 10, 2026.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 54/100
Research direction
Read the CommonMath functions and the REGCA and REPCA model definitions, then follow the extraction approach from issue #640. Move the listed helpers into CommonMath with their equations and tests alongside its existing functions; done means both models use the shared helpers and the associated tests pass.
Written by the indexing model from the issue text.
Description
Summary
Extract the reusable math helpers in REGCA and REPCA into CommonMath.
Rationale
These functions are currently embedded in individual models. They should be reusable and have their equations and tests alongside the other CommonMath functions.
Description
Functions to extract:
- REGCA:
awmax(antiwindup with a moving upper bound) andiramp(inverse smooth ramp). - REPCA:
droop,invertClamp(rename toiclamp,invertDeadband(rename toideadband1/2), and the supportinglogOneMinusExp.
Additional information
Follow-up to #640.
- Dominant language
- C++
- Stars
- 27
- Forks
- 11
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 15
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/GridKit
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ORNL/GridKit#587 · 1 reaction ·
Maintainers usually reply within 1 day
-
Companion OPF models for PD initialization constraintsPossibly taken @lukelowry claimed this 3 days ago. OpenIVP question
ORNL/GridKit#656 · 1 assignee ·
Maintainers usually reply within 1 day
-
enhancement question
Difficulty 5/5 Over a week Newbie friendliness 30/100
ORNL/GridKit#624 · 2 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
Add support for hierarchical modeling to the JSON format case file specificationsPossibly taken @abirchfield claimed this 33 days ago. Opendocumentation enhancement new case question
ORNL/GridKit#619 · 8 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Separate Rosenbrock integrator interface to GridKit from the integrator implementation.May be free again @alexander-novo claimed this 33 days ago, and no pull request is open. Openenhancement new solver
ORNL/GridKit#618 · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day