Handling of zero input parameters
Maintainers usually reply within 1 day
@lukelowry is already working on this.
Since Aug 10, 2026.
Assessment
This issue has not been assessed yet.
Description
Several phasor dynamics models currently use != 0, == 0, != ZERO<RealT> or == ZERO<RealT> for some input parameters to enable/disable some features. This is ill advised for floating point values.
The models currently affected are:
- ESDC1A
- HYGOV
- IEEEST
- IEEET1
- REECB
- REPCA
isEqual with a tolerance or splitting == into isfinite(), <= and >= are inadequate here. The desired behavior really is to check if the value is zero, and the underlying purpose is to enable/disable some options.
One proposed solution is to expose the enabled/disabled options directly as integers (e.g., order for a stabilizer or booleans (e.g. saturation_disabled for an exciter). While this duplicates some information in the input file, this should make the model implementation cleaner. As long as the enabled/disabled features don't change during the simulation, it can be argued that we are mathematically dealing with different models.
cc @pelesh @superwhiskers
- Dominant language
- C++
- Stars
- 27
- Forks
- 11
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 15
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/GridKit
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ORNL/GridKit#587 · 1 reaction ·
Maintainers usually reply within 1 day
-
Companion OPF models for PD initialization constraintsPossibly taken @lukelowry claimed this 3 days ago. OpenIVP question
ORNL/GridKit#656 · 1 assignee ·
Maintainers usually reply within 1 day
-
Extract CommonMath functionsPossibly taken @amandeep25100-a11y claimed this 6 days ago. Opencleanup
Difficulty 4/5 3-5 days Newbie friendliness 54/100
ORNL/GridKit#642 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement question
Difficulty 5/5 Over a week Newbie friendliness 30/100
ORNL/GridKit#624 · 2 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
Add support for hierarchical modeling to the JSON format case file specificationsPossibly taken @abirchfield claimed this 33 days ago. Opendocumentation enhancement new case question
ORNL/GridKit#619 · 8 comments · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day