Do we need `BusInfinite` to inherit from `BusBase`?
Maintainers usually reply within 1 day
@pelesh is already working on this.
Since Jun 24, 2026.
Assessment
This issue has not been assessed yet.
Description
Summary
I suggest to make BusInfinite a standalone class, not inheriting from BusBase. In that case, the system composer would have separate loops for buses and infinite buses. The latter might be needed only for component instantiation and not for allocation, residual evaluation or Jacobian evaluation.
In GridKit phasor dynamics module, similar example is SignalNode, which is also a standalone class.
CC @lukelowry @PhilipFackler @nkoukpaizan @abirchfield
Rationale
Inheritance is "is a" relationship and despite its name infinite bus is not really a bus. Rather it stands in for a connection to a grid that is much larger than the grid being modeled.
The infinite bus does not have internal variables or equations and can be skipped in SystemSolver when allocating workspace, evaluating residual or Jacobian, etc. Without the inheritance, the BusInfinite class could be simplified and BusBase could be merged with Bus class to further simplify the code.
Description
I suggest implementing BusInfinite as a standalone class that is treated separately from the Bus instances. We needed inheritance because component constructors needed pointers to buses. Since ComponentData instance has all the connectivity information for each component, pointers to the buses will be eventually removed.
Additional information
No response
- Dominant language
- C++
- Stars
- 27
- Forks
- 11
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 15
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ORNL/GridKit
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ORNL/GridKit#587 · 1 reaction ·
Maintainers usually reply within 1 day
-
Companion OPF models for PD initialization constraintsPossibly taken @lukelowry claimed this 3 days ago. OpenIVP question
ORNL/GridKit#656 · 1 assignee ·
Maintainers usually reply within 1 day
-
Extract CommonMath functionsPossibly taken @amandeep25100-a11y claimed this 6 days ago. Opencleanup
Difficulty 4/5 3-5 days Newbie friendliness 54/100
ORNL/GridKit#642 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement question
Difficulty 5/5 Over a week Newbie friendliness 30/100
ORNL/GridKit#624 · 2 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
Add support for hierarchical modeling to the JSON format case file specificationsPossibly taken @abirchfield claimed this 33 days ago. Opendocumentation enhancement new case question
ORNL/GridKit#619 · 8 comments · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day