Expand Interrupt ability list
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- ruby
- Domain
- backend-api-design
Research direction
Start by locating the implementation and documentation for the interrupt search operator; the issue does not name specific files or tests. Compare its current matching behavior with the explicitly flagged abilities and the nested "would" and "prevent" abilities listed in the discussion. Done means the operator's results and its syntax page description agree on which cards count.
Written by the indexing model from the issue text.
Description
[5:22 PM]Jamie [they/them]: the true false positives (cards that show up on my search and actually have no interrupt abilities) include:
8 cards with "cannot be prevented" and CtM (the only card with "cannot be avoided")
Net Analytics and Thunder Art Gallery, which have trigger conditions related to interrupts. Guru Davinder's second ability would also put it in this category, but the first ability is an interrupt that's properly captured by both searches
[5:22 PM]Jamie [they/them]: I have 5 categories of cards that show up on my search and arguably should be included in the interrupt search
[5:23 PM]plural [he/him]: hunting grounds and patchwork aren't included in the ability search right now because they have [interrupt], once per turn → in their text
[5:23 PM]Jamie [they/them]: yep that was gonna be the first category
[5:24 PM]Jamie [they/them]: that's the only one that's definitively a bug/parsing-issue rather than a methodology/should-this-count-or-not issue
[5:25 PM]Jamie [they/them]: the second category is bankhar, which is maybe an error on the Rules team's end? I dunno why it doesn't have the interrupt flag, it's got a static condition in the front but fundamentally it's a regular ol' interrupt conditional ability
[5:25 PM]plural [he/him]: i'm not opposed having an allow list of cards with ability matches that we want to match to an ability
[5:27 PM]Jamie [they/them]: category 3 is Leverage and Qianju PT, which both set up delayed conditional abilities that happen to be interrupts. they don't get a glyph because the ability is nested within the paragraph. contrast On the Lam, where we did put an ability flag in the middle of a paragraph because it's a literal quoted-text ability. not sure what we would do if we were making a physical printing of something like On the Lam
[5:28 PM]Jamie [they/them]: category 4 is interrupt conditional abilities nested inside an ability that makes a run. the interrupt nature of all these is indicated by the "would" in the trigger condition. those cards are:
Baker
Dorm Computer
Immolation Script
Maintenance Access
Omar Keung
Shred
Sneakdoor Beta
The Noble Path
Tracker
[5:31 PM]Jamie [they/them]: finally, we have abilities with a built-in prevention effect. this one is the most questionable because we've never been suuuuper clear about the fine details of timing and instruction boundaries when abilities have complex structure like these ones. but I'd still categorize them as interrupts
Alexa Belsky
Credit Crash
Financial Collapse
Game Over
Mr. Hendrik
Snatch and Grab
[5:34 PM]Jamie [they/them]: 50 + 2 = 52 results for interrupt:true
50 + 11 + 2 + 1 + 2 + 9 + 6 = 81 results for x:would|prevent|avoid
ok cool the numbers match, the searches agree on 50 correct cards
[5:40 PM]Jamie [they/them]: anyway this is a lot of detail on one particular operator. y'all can update it to include whichever of these feels appropriate (and reasonable to implement), my only real concern is that the description of the operator on the syntax page should match what it actually does. if it said
Does the card have an ":interrupt: ->" ability?
instead of just "an interrupt ability" then the search results would be accurate as-is (except for patchwork and hunting grounds)
[5:40 PM]Jamie [they/them]: I'm happy to consult further whichever direction you decide to go
[5:41 PM]plural [he/him]: yep, this is great feedback, thanks!
[5:42 PM]plural [he/him]: i'm happy to tag all of these as interrupts if you like. Would you be willing to give me a description that woud cover those i can use for the docs?
[5:47 PM]Jamie [they/them]: you mean, tag these 20 cards?https://netrunnerdb.com/search_new/?q=x%3Awould%7Cinterrupt%7Cprevent+interrupt%3Afalse+x!"cannot+be+prevented"%7C"cannot+be+avoided"
[5:50 PM]Jamie [they/them]: the current interrupt:true results plus those 20 cards would match the current description of "Does the card have an interrupt ability?", but we could give more detail, perhaps like this:
Includes interrupts marked explicitly with the :interrupt: ability flag as well as "would" and "prevent" abilities nested inside another ability .
- Dominant language
- Ruby
- Stars
- 10
- Forks
- 9
- Avg merge
- 2h 59m
- Merged PRs (30d)
- 2
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Null-Signal-Games/netrunnerdb-api-server
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
All issues in Null-Signal-Games/netrunnerdb-api-server
Similar issues
-
Bug Ruby
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
getsentry/sentry-ruby#3211 · 1 comment ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
interest-zsv
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hitobito/hitobito_zsv#6 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ecosyste-ms/issues#862 ·
Maintainers usually reply within 1 day
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day