Expand Interrupt ability list
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- ruby
- Ambito
- backend-api-design
Direzione di ricerca
Start by locating the implementation and documentation for the interrupt search operator; the issue does not name specific files or tests. Compare its current matching behavior with the explicitly flagged abilities and the nested "would" and "prevent" abilities listed in the discussion. Done means the operator's results and its syntax page description agree on which cards count.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
[5:22 PM]Jamie [they/them]: the true false positives (cards that show up on my search and actually have no interrupt abilities) include:
8 cards with "cannot be prevented" and CtM (the only card with "cannot be avoided")
Net Analytics and Thunder Art Gallery, which have trigger conditions related to interrupts. Guru Davinder's second ability would also put it in this category, but the first ability is an interrupt that's properly captured by both searches
[5:22 PM]Jamie [they/them]: I have 5 categories of cards that show up on my search and arguably should be included in the interrupt search
[5:23 PM]plural [he/him]: hunting grounds and patchwork aren't included in the ability search right now because they have [interrupt], once per turn → in their text
[5:23 PM]Jamie [they/them]: yep that was gonna be the first category
[5:24 PM]Jamie [they/them]: that's the only one that's definitively a bug/parsing-issue rather than a methodology/should-this-count-or-not issue
[5:25 PM]Jamie [they/them]: the second category is bankhar, which is maybe an error on the Rules team's end? I dunno why it doesn't have the interrupt flag, it's got a static condition in the front but fundamentally it's a regular ol' interrupt conditional ability
[5:25 PM]plural [he/him]: i'm not opposed having an allow list of cards with ability matches that we want to match to an ability
[5:27 PM]Jamie [they/them]: category 3 is Leverage and Qianju PT, which both set up delayed conditional abilities that happen to be interrupts. they don't get a glyph because the ability is nested within the paragraph. contrast On the Lam, where we did put an ability flag in the middle of a paragraph because it's a literal quoted-text ability. not sure what we would do if we were making a physical printing of something like On the Lam
[5:28 PM]Jamie [they/them]: category 4 is interrupt conditional abilities nested inside an ability that makes a run. the interrupt nature of all these is indicated by the "would" in the trigger condition. those cards are:
Baker
Dorm Computer
Immolation Script
Maintenance Access
Omar Keung
Shred
Sneakdoor Beta
The Noble Path
Tracker
[5:31 PM]Jamie [they/them]: finally, we have abilities with a built-in prevention effect. this one is the most questionable because we've never been suuuuper clear about the fine details of timing and instruction boundaries when abilities have complex structure like these ones. but I'd still categorize them as interrupts
Alexa Belsky
Credit Crash
Financial Collapse
Game Over
Mr. Hendrik
Snatch and Grab
[5:34 PM]Jamie [they/them]: 50 + 2 = 52 results for interrupt:true
50 + 11 + 2 + 1 + 2 + 9 + 6 = 81 results for x:would|prevent|avoid
ok cool the numbers match, the searches agree on 50 correct cards
[5:40 PM]Jamie [they/them]: anyway this is a lot of detail on one particular operator. y'all can update it to include whichever of these feels appropriate (and reasonable to implement), my only real concern is that the description of the operator on the syntax page should match what it actually does. if it said
Does the card have an ":interrupt: ->" ability?
instead of just "an interrupt ability" then the search results would be accurate as-is (except for patchwork and hunting grounds)
[5:40 PM]Jamie [they/them]: I'm happy to consult further whichever direction you decide to go
[5:41 PM]plural [he/him]: yep, this is great feedback, thanks!
[5:42 PM]plural [he/him]: i'm happy to tag all of these as interrupts if you like. Would you be willing to give me a description that woud cover those i can use for the docs?
[5:47 PM]Jamie [they/them]: you mean, tag these 20 cards?https://netrunnerdb.com/search_new/?q=x%3Awould%7Cinterrupt%7Cprevent+interrupt%3Afalse+x!"cannot+be+prevented"%7C"cannot+be+avoided"
[5:50 PM]Jamie [they/them]: the current interrupt:true results plus those 20 cards would match the current description of "Does the card have an interrupt ability?", but we could give more detail, perhaps like this:
Includes interrupts marked explicitly with the :interrupt: ability flag as well as "would" and "prevent" abilities nested inside another ability .
- Lingua principale
- Ruby
- Stelle
- 10
- Fork
- 9
- Merge medio
- 2h 59m
- PR unite (30g)
- 2
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Nessuna guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Null-Signal-Games/netrunnerdb-api-server
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 20/100
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 52/100
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
Tutte le issue di Null-Signal-Games/netrunnerdb-api-server
Issue simili
-
Bug Ruby
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
getsentry/sentry-ruby#3211 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
internetee/registry#2984 ·
I maintainer di solito rispondono entro 6 giorni
-
interest-zsv
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
hitobito/hitobito_zsv#6 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
ecosyste-ms/issues#862 ·
I maintainer di solito rispondono entro 1 giorno
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredForse già presa @mimosa l’ha presa oggi. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno