sanitizeName not applied to names inside stopNodes (quote injection / tag break-out bypass)
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- security
Research direction
The unsanitized names come from buildRawContent() and buildAttributesForStopNode() in fxb.js, and from getRawContent(), attr_to_str_raw() and attr_to_str() in orderedJs2Xml.js. Start by reading how resolveName() is used on the regular path, then route the stopNode paths through it. Done means the three reproduction payloads come out sanitized in both build modes, with regression tests. The issue says PR #33 already implements this, so check that PR before starting.
Written by the indexing model from the issue text.
Description
Description
When a sanitizeName callback is configured, it is applied to tag and attribute names on the regular build path — but not inside stopNodes. This affects both build modes:
fxb.js(plain-object mode):buildRawContent()andbuildAttributesForStopNode()write names to the output without routing them throughresolveName().orderedJs2Xml.js(preserveOrdermode):getRawContent()andattr_to_str_raw()do the same, andattr_to_str()explicitly skips name sanitization whenisStopNodeis true.
Reproduction
const { XMLBuilder } = require("fast-xml-builder");
const builder = new XMLBuilder({
ignoreAttributes: false,
sanitizeName: (n) => n.replace(/[^\w.:-]/g, '_'), // per docs
stopNodes: ["root.raw"],
});
// 1. Quote injection in an attribute name forges a new attribute:
builder.build({ root: { raw: { '#text': 'content', '@_x" onmouseover="alert(1)': 'y' } } });
// <root><raw x" onmouseover="alert(1)="y">content</raw></root>
// 2. '>' in a tag name breaks out of the tag
builder.build({ root: { raw: { 'a href="javascript:x"': 'v' } } });
// <root><raw><a href="javascript:x">v</a href="javascript:x"></raw></root>
// 3. preserveOrder mode is also affected
builder.build([{ root: [{ raw: [{ '#text': 'x' }, { 'a onclick="alert(1)': [{ '#text': 'y' }] }] }] }]);
// <root><raw>x<a onclick="alert(1)">y</a onclick="alert(1)"></raw></root>
The same payload on a non-stopNode path is sanitized correctly (a_href__javascript_x_), so this is an inconsistent bypass of the sanitizeName security control (CWE-74: Special Element Injection) rather than missing-by-design behavior — sanitizeName was introduced in 1.2.0 specifically to guard against injection via invalid XML names.
Impact
Any application that sets both sanitizeName and stopNodes gets no name sanitization for everything inside the stopNode subtree: quotes in attribute names can forge additional attributes, and > can close a tag early, changing document structure for downstream consumers. Round-tripping through the parser yields a structure that differs from what was built, so this can also cause silent data-integrity problems.
Suggested fix
Route both paths through the existing resolveName() helper (pass matcher and qNameValidator down from arrToStr/processTextOrObjNode). PR #33 implements this fix plus regression tests for both build modes.
- Dominant language
- JavaScript
- Stars
- 22
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NaturalIntelligence/fast-xml-builder
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
`preserveOrder: true` with `format: true` formats mixed content wrongly and adds whitespace to content that ends with `>`Possibly taken @neumaennl claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
`XMLBuilder` object should be exported as a named export, not just the typePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
NaturalIntelligence/fast-xml-builder#25 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 54/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 48/100
NaturalIntelligence/fast-xml-builder#4 · 5 comments · 2 reactions ·
All issues in NaturalIntelligence/fast-xml-builder
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Extended search drops any query term that contains a line breakPossibly taken @goranai claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
area:mcp
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day