sanitizeName not applied to names inside stopNodes (quote injection / tag break-out bypass)

Aperta
#34 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

@hicay ci sta già lavorando.

Dal 13/11/2026.

  • #33 di @hicay — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
security

Direzione di ricerca

The unsanitized names come from buildRawContent() and buildAttributesForStopNode() in fxb.js, and from getRawContent(), attr_to_str_raw() and attr_to_str() in orderedJs2Xml.js. Start by reading how resolveName() is used on the regular path, then route the stopNode paths through it. Done means the three reproduction payloads come out sanitized in both build modes, with regression tests. The issue says PR #33 already implements this, so check that PR before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

When a sanitizeName callback is configured, it is applied to tag and attribute names on the regular build path — but not inside stopNodes. This affects both build modes:

  • fxb.js (plain-object mode): buildRawContent() and buildAttributesForStopNode() write names to the output without routing them through resolveName().
  • orderedJs2Xml.js (preserveOrder mode): getRawContent() and attr_to_str_raw() do the same, and attr_to_str() explicitly skips name sanitization when isStopNode is true.

Reproduction

const { XMLBuilder } = require("fast-xml-builder");

const builder = new XMLBuilder({
  ignoreAttributes: false,
  sanitizeName: (n) => n.replace(/[^\w.:-]/g, '_'), // per docs
  stopNodes: ["root.raw"],
});

// 1. Quote injection in an attribute name forges a new attribute:
builder.build({ root: { raw: { '#text': 'content', '@_x" onmouseover="alert(1)': 'y' } } });
// <root><raw x" onmouseover="alert(1)="y">content</raw></root>

// 2. '>' in a tag name breaks out of the tag
builder.build({ root: { raw: { 'a href="javascript:x"': 'v' } } });
// <root><raw><a href="javascript:x">v</a href="javascript:x"></raw></root>

// 3. preserveOrder mode is also affected
builder.build([{ root: [{ raw: [{ '#text': 'x' }, { 'a onclick="alert(1)': [{ '#text': 'y' }] }] }] }]);
// <root><raw>x<a onclick="alert(1)">y</a onclick="alert(1)"></raw></root>

The same payload on a non-stopNode path is sanitized correctly (a_href__javascript_x_), so this is an inconsistent bypass of the sanitizeName security control (CWE-74: Special Element Injection) rather than missing-by-design behavior — sanitizeName was introduced in 1.2.0 specifically to guard against injection via invalid XML names.

Impact

Any application that sets both sanitizeName and stopNodes gets no name sanitization for everything inside the stopNode subtree: quotes in attribute names can forge additional attributes, and > can close a tag early, changing document structure for downstream consumers. Round-tripping through the parser yields a structure that differs from what was built, so this can also cause silent data-integrity problems.

Suggested fix

Route both paths through the existing resolveName() helper (pass matcher and qNameValidator down from arrToStr/processTextOrObjNode). PR #33 implements this fix plus regression tests for both build modes.

Lingua principale
JavaScript
Stelle
22
Fork
9
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NaturalIntelligence/fast-xml-builder

Tutte le issue di NaturalIntelligence/fast-xml-builder

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.