sanitizeName not applied to names inside stopNodes (quote injection / tag break-out bypass)

Abierto
#34 1 comentario 0 reacciones 0 asignados Ver en GitHub

@hicay ya está trabajando en esto.

Desde el 13/11/2026.

  • #33 de @hicay — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript
Área
security

Línea de trabajo

The unsanitized names come from buildRawContent() and buildAttributesForStopNode() in fxb.js, and from getRawContent(), attr_to_str_raw() and attr_to_str() in orderedJs2Xml.js. Start by reading how resolveName() is used on the regular path, then route the stopNode paths through it. Done means the three reproduction payloads come out sanitized in both build modes, with regression tests. The issue says PR #33 already implements this, so check that PR before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

When a sanitizeName callback is configured, it is applied to tag and attribute names on the regular build path — but not inside stopNodes. This affects both build modes:

  • fxb.js (plain-object mode): buildRawContent() and buildAttributesForStopNode() write names to the output without routing them through resolveName().
  • orderedJs2Xml.js (preserveOrder mode): getRawContent() and attr_to_str_raw() do the same, and attr_to_str() explicitly skips name sanitization when isStopNode is true.

Reproduction

const { XMLBuilder } = require("fast-xml-builder");

const builder = new XMLBuilder({
  ignoreAttributes: false,
  sanitizeName: (n) => n.replace(/[^\w.:-]/g, '_'), // per docs
  stopNodes: ["root.raw"],
});

// 1. Quote injection in an attribute name forges a new attribute:
builder.build({ root: { raw: { '#text': 'content', '@_x" onmouseover="alert(1)': 'y' } } });
// <root><raw x" onmouseover="alert(1)="y">content</raw></root>

// 2. '>' in a tag name breaks out of the tag
builder.build({ root: { raw: { 'a href="javascript:x"': 'v' } } });
// <root><raw><a href="javascript:x">v</a href="javascript:x"></raw></root>

// 3. preserveOrder mode is also affected
builder.build([{ root: [{ raw: [{ '#text': 'x' }, { 'a onclick="alert(1)': [{ '#text': 'y' }] }] }] }]);
// <root><raw>x<a onclick="alert(1)">y</a onclick="alert(1)"></raw></root>

The same payload on a non-stopNode path is sanitized correctly (a_href__javascript_x_), so this is an inconsistent bypass of the sanitizeName security control (CWE-74: Special Element Injection) rather than missing-by-design behavior — sanitizeName was introduced in 1.2.0 specifically to guard against injection via invalid XML names.

Impact

Any application that sets both sanitizeName and stopNodes gets no name sanitization for everything inside the stopNode subtree: quotes in attribute names can forge additional attributes, and > can close a tag early, changing document structure for downstream consumers. Round-tripping through the parser yields a structure that differs from what was built, so this can also cause silent data-integrity problems.

Suggested fix

Route both paths through the existing resolveName() helper (pass matcher and qNameValidator down from arrToStr/processTextOrObjNode). PR #33 implements this fix plus regression tests for both build modes.

Lenguaje dominante
JavaScript
Estrellas
22
Forks
9
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NaturalIntelligence/fast-xml-builder

Todos los issues de NaturalIntelligence/fast-xml-builder

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.