Site dark mode: IMPORTANT callouts render as light text on a white box
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- css
- Domain
- frontend
Research direction
Start with src/site/resources/css/site.css and compare its alternate color variables with the dark-mode IMPORTANT callout rule shown in the issue. Add the targeted body.dark .callout.callout-important override described there, then verify that IMPORTANT callouts have readable text and background colors in dark mode.
Written by the indexing model from the issue text.
Description
Where: src/site/resources/css/site.css (MetricsHub colors), with Sentry Maven Skin 8.
What happens: in dark mode, an > [!IMPORTANT] callout renders as a white box with light text, which is unreadable.
The skin styles IMPORTANT callouts with the alternate colors, and swaps them in dark mode (published css/main-combined.css):
.callout.callout-important { --callout-bg: var(--alternate-bgcolor); --callout-fg: var(--alternate-fgcolor); }
body.dark .callout.callout-important { --callout-bg: var(--alternate-fgcolor); --callout-fg: var(--alternate-bgcolor); }
Our site.css sets --alternate-bgcolor: #266fd0 and --alternate-fgcolor: #fff and does not override them in body.dark, so in dark mode the callout background becomes #fff. The callout's body text keeps the dark-mode foreground (#e9ecef), so it is light text on white.
Impact today: none of the current pages uses an IMPORTANT callout, so the bug is latent. It shows up as soon as a page adds one. It was found in ipmi-java, which copied this site.css (MetricsHub/ipmi-java#113).
Suggested fix: the fix applied in ipmi-java, appended to site.css:
/* The skin inverts the alternate colors for IMPORTANT callouts in dark mode, which turns our white-on-blue
palette into a white box with light text */
body.dark .callout.callout-important {
--callout-bg: var(--main-bgcolor);
--callout-fg: var(--link-color);
}
Overriding --alternate-fgcolor in body.dark instead would also darken the text that the skin draws on the blue alternate background (active menu item, ...), so the targeted rule is safer. The other MetricsHub projects that share this site.css probably have the same latent bug. The skin's dark rule could arguably handle a light --alternate-fgcolor itself.
- Dominant language
- Java
- Stars
- 13
- Forks
- 4
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 15
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MetricsHub/winrm-java
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 58/100
MetricsHub/winrm-java#201 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 78/100
MetricsHub/winrm-java#199 ·
Maintainers usually reply within 1 day
-
Streaming command fails with a spurious timeout when reconnecting after an idle pausePossibly taken @NassimBtk claimed this 1 day ago. Open
MetricsHub/winrm-java#198 · 1 assignee ·
Maintainers usually reply within 1 day
-
Long-lived `WinRMClient` keeps failing with WSManFault 2150859174 after a terminate Signal failsPossibly taken @NassimBtk claimed this 1 day ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 25/100
MetricsHub/winrm-java#196 · 4 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
MetricsHub/winrm-java#194 ·
Maintainers usually reply within 1 day
All issues in MetricsHub/winrm-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
C21 publishes `reactivemongo/core/SSL` as Java 23 bytecode — TLS connections fail on any JDK < 23Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ReactiveMongo/ReactiveMongo#1520 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
liquid-java/liquidjava#373 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ga4gh/phenopacket-schema#465 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NationalSecurityAgency/ghidra#9748 ·
Maintainers usually reply within 1 day