Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

WQL array properties: add the trailing separator to match wmi-java

Open
  • Is something wrong?
#201 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
backend

Research direction

Start by reading the WqlRow Javadoc and the array-property rendering, then check how WinRMClient.Builder.arraySeparator(String) configures the separator. Run the project tests and check the array-rendering cases. Done means array elements have the agreed trailing-separator behavior, the empty-array choice is explicit, and WqlRow Javadoc, wql.md and the CHANGELOG describe it.

Written by the indexing model from the issue text.

Description

enhancement

Problem

Since 3.0.00 (#189), a WMI array property is rendered by joining its elements with the separator: 192.0.2.10|fe80::1.

wmi-java renders the same array with a trailing separator: WmiStringConverter joins with Collectors.joining(arraySeparator, "", arraySeparator), after stripping the separator from each element, which yields 192.0.2.10|fe80::1| (an empty array yields |).

MetricsHub connectors run the same WQL queries through both libraries (WMI extension on Windows collectors, WinRM extension elsewhere), and their AWK scripts and split computes were written against the wmi-java output. The two libraries must produce the same string.

Proposal

Align winrm-java on wmi-java:

  • append the separator after the last element (a|b|), including for a single element (a|);
  • strip the separator from each element before joining, as wmi-java does;
  • keep | as the default and WinRMClient.Builder.arraySeparator(String) as the override.

Decide explicitly what an empty array renders as (wmi-java gives |; an empty string may be more useful) and document it in the WqlRow Javadoc, wql.md and the CHANGELOG.

The change only affects array properties, which 2.x truncated to their last element anyway, so no caller can depend on the 3.0.00 form yet.

Dominant language
Java
Stars
13
Forks
4
Avg merge
7h 38m
Merged PRs (30d)
14

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetricsHub/winrm-java

All issues in MetricsHub/winrm-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.