Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Saving a shared view from the view config panel skips the shared-view warning

Open Beginner friendly
  • Is something wrong?
#5,837 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

Start with onSaveView in mj-view-workspace and compare it with onQuickSave, which already opens the shared-view warning. Trace how the save event is held and how CurrentViewEntity?.IsShared is checked. The change is done when both save paths show the same warning before overwriting a shared view, with regression coverage added if an existing nearby test location is found.

Written by the indexing model from the issue text.

Description

bug
Summary

The quick-save dialog warns before overwriting a shared view, but saving from the view config panel (onSaveView) does not. A user editing the columns of a shared view overwrites it for everyone with no warning; only the server's ownership check stands in the way. A fix routes onSaveView through the same warning.

What happened

Follow-up from bizapps-orders PR #243 (known MJ limitation), never filed. https://github.com/MemberJunction/bizapps-orders/pull/243

Expected: the same shared-view warning on both save paths.
Actual: the config panel's Save writes the shared view directly.

Steps to reproduce
  1. Open a shared view you own in mj-view-workspace with AutoSaveView on.
  2. Change columns in the config panel and press Save.
  3. No warning; the shared view changes for every user.
Confidence

Inferred from code, not observed

Environment

MJ 6.1.5 · bizapps-orders @ next 8e104ce9
MJ next f6faded5 (same code)

Severity proposed

minor

Target line

next

Duplicate search

Searched "shared view warning" (MemberJunction/MJ) — found #3239 (unrelated: private view execution), none for this.

Blocking?

Not blocked.

Proposed fix (optional) — tested? no

Proposed: in onSaveView, when !event.SaveAsNew && this.CurrentViewEntity?.IsShared, hold the event and open the shared-view warning, as onQuickSave does.
Tested: no

Dominant language
TSQL
Stars
32
Forks
7
Avg merge
1d 12h
Merged PRs (30d)
682

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MemberJunction/MJ

All issues in MemberJunction/MJ

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.