view-workspace's SelectedView input does not update the view selector
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with the SelectedView setter on the <mj-view-workspace> component and trace how it passes state to the grid and view selector. Set SelectedViewId from the incoming view's ID, falling back to null, and verify that hosting the element highlights the same view shown by the grid.
Written by the indexing model from the issue text.
Description
Summary
When a host passes a view through mj-view-workspace's [SelectedView] input, the grid shows that view but the view selector does not highlight it, because the setter never updates selectedViewId. A fix sets the selected ID from the view in the setter.
What happened
Follow-up from bizapps-orders PR #243 (known MJ limitation), never filed. https://github.com/MemberJunction/bizapps-orders/pull/243
The orders grids open on the shared "Orders: Working" view through [SelectedView]; the selector shows no selection.
Expected: the selector highlights the view the workspace is showing.
Actual: nothing is highlighted.
Steps to reproduce
- Host
<mj-view-workspace [SelectedView]="someView">. - The grid shows the view; the selector has no selected item.
Confidence
Inferred from code, not observed
Environment
MJ 6.1.5 · bizapps-orders @ next 8e104ce9
MJ next f6faded5 (same code)
Severity proposed
minor
Target line
next
Duplicate search
Searched "SelectedView", "view-workspace SelectedView", "view selector highlight" (MemberJunction/MJ) — none found.
Blocking?
Not blocked.
Proposed fix (optional) — tested? no
Proposed: in the setter, this.SelectedViewId = value?.ID ?? null;.
Tested: no
- Dominant language
- TSQL
- Stars
- 32
- Forks
- 7
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 682
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MemberJunction/MJ
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
MemberJunction/MJ#5864 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
MemberJunction/MJ#5859 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MemberJunction/MJ#5837 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MemberJunction/MJ#5832 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
MemberJunction/MJ#5831 ·
Maintainers usually reply within 1 day
All issues in MemberJunction/MJ
Similar issues
-
os:linux
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
mpv-player/mpv#18649 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ccch1mneyyy/dsh-TUI#1631 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
olahol/react-tagsinput#229 ·
-
area/busola/ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
kyma-project/busola#5442 ·
Maintainers usually reply within 2 days