TP-based metrics fail to compute correct values with duplicates in interactions

Open
  • Is something wrong?
#164 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
machine-learning

Research direction

Start by locating the classification and ranking metrics that compute precision and inspect how they handle duplicate test interactions. Reproduce the reported case with duplicate interactions and compare the result with the expected value of 1/3. Done means the affected metrics return the correct values for this case; the issue names no files or tests to run.

Written by the indexing model from the issue text.

Description

bug
What happened?

Precision (and other Calssification and Ranking metrics) is not correct when there are duplicates in test interactions. See screenshot

Expected behavior

I suppose that correct value should be 1/3 because 2/3 of reco lists are False Positives.

Relevant logs and/or screenshots
Снимок экрана 2024-07-17 в 14 36 39
Operating System

macOS Big Sur 11.6 (Apple M1)

Python Version

any

RecTools version

0.6.0

Dominant language
Python
Stars
457
Forks
55
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MTSWebServices/RecTools

All issues in MTSWebServices/RecTools

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.