Params default values duplication in model and its config

Open
  • Is something wrong?
#249 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
machine-learning

Research direction

Start by comparing how RecTools models define parameter defaults with how their configs define the same values; the issue does not name specific files or tests. Decide where defaults should live and how model configuration should consume them, then check that every model uses one consistent default value.

Written by the indexing model from the issue text.

Description

enhancement
Feature Description

We are duplicating param defaults in model and its config for all of RecTools models. Find a way to avoid duplication (maybe remove defaults from configs at all)

Why this feature?

We might easily ave different default values in model and in model config

Additional context

No response

Dominant language
Python
Stars
457
Forks
55
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MTSWebServices/RecTools

All issues in MTSWebServices/RecTools

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.