Correct the documented phi-function recurrence join

Open Beginner friendly
#627 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
documentation

Research direction

Read the module introduction in src/solprop/backends/exponential.py alongside PHI_JOIN = 3.0 and its existing rationale. Correct the three overview inequalities to match the join at 3 while retaining the derivation and qualification rationale. Done means the overview and implementation agree and the changed-file spelling and documentation checks pass.

Written by the indexing model from the issue text.

Description

documentation priority: low

What happens

The module introduction in src/solprop/backends/exponential.py describes a near/far split at |x| = 8, while the implementation's PHI_JOIN is 3.0 and its detailed rationale describes the split at 3. The near-series and far-recurrence inequalities therefore disagree within the same file.

Why it matters

The module is the numerical reference for other backends. Its stale overview can cause an implementing backend to use a different numerical branch domain.

Reproduction

Read, not a numerical run: compare the introductory near/away bullets with PHI_JOIN = 3.0 and its docstring in the inspected source. The constant and detailed rationale agree with the implemented split; the introduction does not.

Context

Found during SEP 48 implementation #611, tracking #608. This is a documentation correction, with no proposed change to coefficients, arithmetic or defaults.

To do

  • Correct all three overview inequalities to match PHI_JOIN.
  • Retain the existing derivation and qualification rationale.

Done when

The overview and implementation consistently describe the join at 3; changed-file spelling and documentation checks pass.

Dominant language
Python
Stars
3
Forks
3
Avg merge
8h 28m
Merged PRs (30d)
176

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LupoLab/solprop

All issues in LupoLab/solprop

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.