The off-band split-step finish xfail quotes a departure of 1.1e-8; it measures 2.186e-8

Open Beginner friendly
#616 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
testing-qa

Research direction

Read tests/backends/test_native_planar_statistics.py, especially test_a_finish_with_content_off_the_band_is_the_reference_s_on_it at the linked lines. Run that test with --runxfail on Linux x86-64 and compare the reported departure with the reason and docstring. Update both to match the measured value and state its reference; done when they agree with the run.

Written by the indexing model from the issue text.

Description

area: native priority: low testing
What happens

test_a_finish_with_content_off_the_band_is_the_reference_s_on_it is a strict xfail. It
covers SEP 43 inventory 35: native's split-step finish masks only after the temporal
absorber. Its reason says "1.1e-8 against 3.2e-12", and its docstring says "Measured
1.1e-8 at unit content off the band"
(test_native_planar_statistics.py#L217-L231).
Run with --runxfail, it reports:

AssertionError: the finish: departure 2.186e-08 exceeds the bound 3.183e-12

The bound matches the quoted value. The departure is about twice the quoted value. The
number was written in 1ab3a8d7; whether the departure moved since (for example with
SEP 47's native session) or was never 1.1e-8 is not yet known.

Why it matters

The reason string is the only record of how far native is from the reference on this
input. A reader who sizes the fix from it is off by a factor of two. Because the xfail is
strict but checks no size, a further change in the departure goes unnoticed.

To do
  • Correct both numbers to the measured departure and say what it is relative to.
  • Optionally, record the departure (record_property) or assert its order inside the
    xfail, so that a change of size shows.
  • If main measures 1.1e-8, say in the issue or the commit what on this branch
    moved it.
Done when

The reason and the docstring state the value that --runxfail prints, on Linux x86-64.

Dominant language
Python
Stars
3
Forks
3
Avg merge
8h 28m
Merged PRs (30d)
176

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LupoLab/solprop

All issues in LupoLab/solprop

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.