WHEN will the kornia.geometry.transform.pyramid import issue be fixed?

Open
  • Is something wrong?
#561 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
15/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python, pytorch
Domain
ai

Research direction

The breakage is in custom_nodes/ComfyUI-LTXVideo/pyramid_blending.py, where the kornia import block still lists pad and two calls use pad(. Before editing, check the five open PRs the issue links (#498, #506, #508, #516, #551) since they already carry the one-line fix and the work is already under way. Done means the module imports without kornia's removed pad and the node loads with F.pad calls.

Written by the indexing model from the issue text.

Description

Kornia devs clearly stated that this ia a downsteam issue and has to be fixed in LTX Video.
Why ist this still being ignored? I am fed of fixing this each time manually after an LTX update.

https://github.com/kornia/kornia/issues/3986#issuecomment-5424466053
Copy and paste from above link:

Closing — this is a real break we caused, but the fix belongs downstream, not in kornia.

pad was never public API in kornia.geometry.transform.pyramid: never in __all__, never documented, just torch.nn.functional.pad leaking out of the module because of a from kornia.core import ..., pad, ... import. When the module switched to calling F.pad(...) directly for 0.8.3, that binding disappeared with it. Restoring it would freeze an accidental implementation detail into our API surface permanently, so I've closed https://github.com/kornia/kornia/pull/4003 which proposed exactly that.

ComfyUI-LTXVideo already has five open PRs with the one-line fix (https://github.com/Lightricks/ComfyUI-LTXVideo/pull/498, https://github.com/Lightricks/ComfyUI-LTXVideo/pull/506, https://github.com/Lightricks/ComfyUI-LTXVideo/pull/508, https://github.com/Lightricks/ComfyUI-LTXVideo/pull/516, https://github.com/Lightricks/ComfyUI-LTXVideo/pull/551), oldest from 25 May. I've asked them to merge one and apologized on our behalf for the breakage: https://github.com/Lightricks/ComfyUI-LTXVideo/issues/542#issuecomment-5424461135

Immediate workaround for affected users: in custom_nodes/ComfyUI-LTXVideo/pyramid_blending.py, remove pad, from the kornia import block and change the two pad( calls to F.pad( — torch.nn.functional is already imported as F in that file. Prefer this over pinning kornia==0.8.2, since kornia is shared across node packs in a ComfyUI venv.

Dominant language
Python
Stars
4.2k
Forks
508
Avg merge
7h 14m
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Lightricks/ComfyUI-LTXVideo

All issues in Lightricks/ComfyUI-LTXVideo

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.