Import failed - Possible upstream changes

Open
  • Is something wrong?
#531 17 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
machine-learning

Research direction

The failing import is on line 7 of embeddings_connector.py, which pulls names from comfy.ldm.lightricks.model; the traceback runs through gemma_encoder.py and text_embeddings_connectors.py. First check whether interleaved_freqs_cis still exists in the installed ComfyUI's comfy/ldm/lightricks/model.py and what the linked upstream commit changed in its place. Done means the custom node imports cleanly against current ComfyUI. The thread has 17 comments and no linked pull request, so read it for any agreed direction before starting.

Written by the indexing model from the issue text.

Description

[WARNING] Traceback (most recent call last):
  File "C:\ComfyUI\ComfyUI\nodes.py", line 2247, in load_custom_node
    module_spec.loader.exec_module(module)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "<frozen importlib._bootstrap_external>", line 1027, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-LTXVideo\__init__.py", line 14, in <module>
    from .gemma_encoder import LTXVGemmaCLIPModelLoader, LTXVGemmaEnhancePrompt
  File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-LTXVideo\gemma_encoder.py", line 23, in <module>
    from .text_embeddings_connectors import load_text_embeddings_pipeline
  File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-LTXVideo\text_embeddings_connectors.py", line 18, in <module>
    from .embeddings_connector import (
    ...<3 lines>...
    )
  File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-LTXVideo\embeddings_connector.py", line 7, in <module>
    from comfy.ldm.lightricks.model import (
    ...<7 lines>...
    )
ImportError: cannot import name 'interleaved_freqs_cis' from 'comfy.ldm.lightricks.model' (C:\ComfyUI\ComfyUI\comfy\ldm\lightricks\model.py)

Comfyui was updated: https://github.com/Comfy-Org/ComfyUI/commit/7c59a078d60c85baded8789f10c841221bff80a8

Possibly related (i have not viewed the actual changes in that PR).

Dominant language
Python
Stars
4.2k
Forks
508
Avg merge
7h 14m
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Lightricks/ComfyUI-LTXVideo

All issues in Lightricks/ComfyUI-LTXVideo

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.