Align Unified Search visibility with participant access rules
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 18/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- php
- Domain
- authorization, search
Research direction
Start by reading how lib/Search/FileSearchProvider.php filters results and how lib/Service/FileAccessService.php decides document access, then compare the participant lookups in lib/Db/SignRequestMapper.php and the identification types in lib/Db/IdentifyMethod.php. The issue asks for a written role/identity/state matrix before any code change, so the first deliverable is that contract, checked against tests/php/Unit/Service/FileAccessServiceTest.php. Done means the matrix is agreed and the positive and negative cases pass, and any separately exploitable finding goes through SECURITY.md, not a public pull request.
Written by the indexing model from the issue text.
Description
Goal
Ensure LibreSign Unified Search uses consistent participant identity and document-access rules for owners, signers and observers.
Starting points
lib/Search/FileSearchProvider.phplib/Db/SignRequestMapper.phplib/Service/FileAccessService.phplib/Db/IdentifyMethod.phplib/Db/SignRequest.phptests/php/Unit/Service/FileAccessServiceTest.php- Existing observer integration scenarios
Requirements
Define and implement a consistent, testable contract for search discovery.
Account UID associations should be handled explicitly. Email and other identification channels require a verified rule for associating the contact with the authenticated account; merely comparing arbitrary contact strings must not expand access.
Cover current signing-request states, observers, envelopes, draft requests, deleted accounts and legacy records.
Search discovery must not confer signing, validation or document-management permissions.
Keep discovery decisions consistent with document-access checks without introducing per-result authorization queries that undermine performance.
Acceptance criteria
- A concise role/identity/state matrix documents expected visibility.
- Owners, account signers and account observers receive the correct results.
- Ambiguous or untrusted identifiers do not grant unintended discovery.
- Unrelated accounts receive no document identifiers or metadata.
- Multiple identification methods do not create duplicate results.
- Revoked, stale and deleted-account scenarios have defined outcomes.
- Search-related authorization checks are read-only.
- Unit and database integration tests cover positive and negative cases.
- Existing legitimate signing and validation flows remain compatible.
Implementation guidance
Use the existing services as the starting point. Establish the authorization contract first, then implement the smallest change that satisfies it.
Avoid an independent new permission framework or a repository-wide refactor.
If investigation suggests a separately exploitable security issue, follow SECURITY.md instead of describing exploitation details in a public pull request.
- Dominant language
- PHP
- Stars
- 844
- Forks
- 176
- Avg merge
- 14h 3m
- Merged PRs (30d)
- 344
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LibreSign/libresign
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnfPossibly taken @vitormattos claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#9366 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
LibreSign/libresign#9007 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#8284 · 5 comments ·
Maintainers usually reply within 1 day
-
frontend javascript technical debt
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in LibreSign/libresign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletonsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day