Expected behavior for repeated `fit!` calls

Open
#215 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
julia

Research direction

Start by examining the fit! entry point and the existing repeated-call behavior described for SymbolicRegression.jl. Determine and document the intended warm-start contract for a second fit!, including how the N parameter should behave; no specific files or tests are named in the issue.

Written by the indexing model from the issue text.

Description

Just wondering what the right strategy is for warm starts. What is the correct behavior for calling fit! on a machine twice? Here, I assume that the model has an $N$ parameter controlling the number of optimization steps:

model = Regressor(N=N)
mach = machine(model, X, y)
fit!(mach)
fit!(mach)  # what happens here?
  1. Warm start; runs for another $N$ steps from where it left off.
  2. Warm start; runs for $0$ steps from where it left off. In other words, the user would need to increase $N$ if they want to replicate the behavior of (1)
    fit!(mach)
    mach.model.N += N
    fit!(mach)
    
  3. Cold start; resets the search state and runs for $N$ steps. Perhaps you need to use an update! function for explicit warm starts (in which case 1 and 2 would require using update! instead)

Right now, SymbolicRegression.jl is doing 2. But I'm not sure about this. Pinging @ablaom for tips.

Dominant language
Julia
Stars
39
Forks
8
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaAI/MLJModelInterface.jl

All issues in JuliaAI/MLJModelInterface.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.