Get rid of separate `metadata_pkg`

Open
#189 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
julia
Domain
tooling

Research direction

The issue names metadata_pkg, metadata_model, and the is_wrapper trait but no files or tests. Begin by locating those definitions and inventorying the traits in metadata_pkg; done means the traits are consolidated under metadata_model and the separate metadata_pkg is no longer needed.

Written by the indexing model from the issue text.

Description

next major release

I don't understand why we need a separate metadata_pkg when we have metadata_model, as both take a model type as first argument. We should just move all the traits into the latter.

I was recently confused to find is_wrapper trait, in metadata_pkg, before I realised "pkg" does not necessarily mean global to the package, despite the name.

Dominant language
Julia
Stars
39
Forks
8
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaAI/MLJModelInterface.jl

All issues in JuliaAI/MLJModelInterface.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.