`params(::MLJType)` method

Open
#173 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
julia
Domain
api

Research direction

Start by locating the params(::MLJType) method and the MLJBase re-export mentioned in the issue. Check whether old tutorials still reference the method and identify the compatibility impact. Done means the field-based method is removed without leaving a broken MLJBase re-export or undocumented references.

Written by the indexing model from the issue text.

Description

next major release

I would like to remove this method, as it's essentially "wrong", because it is field-based, instead of property-based. It is my understanding that the method does not appear in any documentation but it may appear in some old tutorials. Unfortunately, it is re-exported by MLJBase, and so removing it will break MLJBase 😢

Dominant language
Julia
Stars
39
Forks
8
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from JuliaAI/MLJModelInterface.jl

All issues in JuliaAI/MLJModelInterface.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.