invalid model parameters should either error or keep user arguments
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- julia
- Domain
- machine-learning
Research direction
No file, test, or entry point is named. Start by locating model constructor parameter validation and the code that falls back to defaults with a warning, then reproduce the behavior with an invalid parameter. The desired outcome still needs maintainer agreement: error on invalid input or preserve the user argument while reporting the validation failure.
Written by the indexing model from the issue text.
Description
I noticed today that if a model constructor fails parameter validation it reverts to the default with a warning.
I find this behavior confusing. Normally invalid constructors lead to an error. Alternatively, I can imagine getting frustrated if an overzealous maintainer improperly restricted a parameter range, in which case the thing to do would be to allow the user-provided argument with an error. Either way, reverting to the default seems like a very strange behavior, thoughts?
- Dominant language
- Julia
- Stars
- 39
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaAI/MLJModelInterface.jl
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJModelInterface.jl#215 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#212 · 26 comments ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#209 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJModelInterface.jl#208 · 2 comments ·
-
next major release
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#189 ·
All issues in JuliaAI/MLJModelInterface.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Sienna-Platform/PowerSimulations.jl#1737 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FluxML/Optimisers.jl#254 ·
-
Minor: floodplain warning percentage, scalar output error message and a never-true identity checkOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JuliaAI/MLJTransforms.jl#101 ·
Maintainers usually reply within 1 day
-
@contents blocks fail to render on Julia 1.14Possibly taken @sbfnk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LuxDL/DocumenterVitepress.jl#410 ·