Don't export `scitype` method.
Nobody has claimed this yet.
- #135 by @OkonSamuel — closed without merging
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
Research direction
Start by reading the scitype definitions and exports in MLJModelInterface, then inspect the workaround in MLJBase/src/MLJBase.jl and the corresponding method in MLJBase/src/Interface/data_utils.jl. Confirm that scitype is no longer exported from MLJModelInterface, that qualified use remains available, and that the method import clash is resolved.
Written by the indexing model from the issue text.
Description
Due to a recent change in ScientificTypesBase,jl from version 2.0 to 3.0, the ScientifictypesBase.scitype method is now a two argument method. Packages depending on MLJModelInterface.jl previously depended on the previous one argument version defined in version 2.0 series of ScientifictypesBase package.
A workaround is needed to avoid making MLJModelInterface breaking for its's users. This involves
- Defining a one argument
scitypemethod in MLJModelInterface. Something in the lines of
scitype(X) = scitype(get_interface_mode(), X)
scitype(::LightInterface, X) = throw(ArgumentError("FullInterface is needed..."))
The corresponding FullInterface method would be implemented at MLJBase/src/Interface/data_utils.jl.
- exporting the
scitypemethod atMLJModelInterface(Needed as users expect that thescitypemethod is exported. see #129 )
But implementing the second step also leads to method import clashes with ScientificTypes.scitype at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward the scitype method shouldn't be exported. Hence users that want to use the scitype method would have to qualify it with the package name e.g. MLJModelinterface.scitype(X).
- Dominant language
- Julia
- Stars
- 39
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaAI/MLJModelInterface.jl
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJModelInterface.jl#215 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#212 · 26 comments ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#209 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJModelInterface.jl#208 · 2 comments ·
-
next major release
Difficulty 4/5 3-5 days Newbie friendliness 35/100
JuliaAI/MLJModelInterface.jl#189 ·
All issues in JuliaAI/MLJModelInterface.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Sienna-Platform/PowerSimulations.jl#1737 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FluxML/Optimisers.jl#254 ·
-
Minor: floodplain warning percentage, scalar output error message and a never-true identity checkOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JuliaAI/MLJTransforms.jl#101 ·
Maintainers usually reply within 1 day
-
@contents blocks fail to render on Julia 1.14Possibly taken @sbfnk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LuxDL/DocumenterVitepress.jl#410 ·