react 19: the Dependabot halves cannot resolve alone, so the bump needs one combined PR

Open Beginner friendly
#403 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

@IanoNjuguna is already working on this.

Since Nov 22, 2026.

  • #404 by @IanoNjuguna — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, react, typescript

Research direction

Start in website/package.json, then check website/package-lock.json and .github/workflows/deploy.yml; the two failing Dependabot halves are #401/#402 and explain why an unmerged lockfile breaks the Pages deploy. In website, bump react, react-dom and @types/react-dom, regenerate the lockfile with npm install, then verify with npm ci and npm run build. Done means the combined PR installs cleanly and the build passes; leave the stale yarn packageManager/resolutions cleanup for a separate change.

Written by the indexing model from the issue text.

Description

dependencies

Dependabot opened the react 19 major as two PRs, and neither can pass on its own:

  • #401 bumps react 18.3.1 to 19.3.1
  • #402 bumps react-dom and @types/react-dom to 19.3.1 / 19.3.0

Each half breaks the other's peer requirement, so both fail npm ci with ERESOLVE:

#402: Found: [email protected]
      Could not resolve dependency: peer react@^19.3.1 from [email protected]

#401: Found: [email protected]
      Could not resolve dependency: peer react-dom@^18.3.1 from [email protected]

Merging them one after the other does not fix it either. deploy.yml runs on every push to main, so between the two merges the tracked lockfile does not resolve, the build job fails, and the Pages deploy is skipped. Any PR opened in that window inherits the same broken lockfile.

Proposed fix

One PR that takes the peer set together, with a regenerated lockfile:

  • react and react-dom to ^19.3.1
  • @types/react-dom to ^19.3.0 (19.3.1 does not exist)

Verified locally against main at 973801b:

  • npm install with the bumped versions: 1409 packages, no ERESOLVE
  • npm ci against the regenerated website/package-lock.json: exit 0
  • npm run build: SUCCESS, static files generated

@docusaurus/core 3.10.2 declares react ^18.0.0 || ^19.0.0, so 19 is inside the supported range. The @slorber/react-helmet-async alias it depends on prints a peer warning capped at react 18, and the install still exits 0.

Related, separate

website/package.json still carries packageManager: [email protected] and a resolutions block pinning react and react-dom to ^18.3.1, both stale since the repo standardised on npm. A yarn install would put react 18 back. npm ignores both, so this does not block the bump, but it should be cleaned up in its own change.

Also worth considering: a groups entry in .github/dependabot.yml covering the peer set, so the next react major arrives as one PR instead of two unresolvable halves.

Dominant language
TypeScript
Stars
13
Forks
24
Avg merge
2d 3h
Merged PRs (30d)
16

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IntersectMBO/developer-experience

All issues in IntersectMBO/developer-experience

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.