recover the review hook lock after a killed delivery
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
Research direction
Open scripts/review-hook.sh at b96823b and find the mkdir acquisition of $RUNNER_TEMP/injected-deliveries.lock, the until mkdir ...; do sleep 0.01; done loop, and the EXIT trap that removes it. Reproduce first by creating the lock directory and running timeout 1 bash scripts/review-hook.sh with a Stop payload; it should exit 124 with no output. Done means the wait is bounded and a stale lock (dead owner PID or old age) is reclaimed while deliveries stay serialized, verified by re-running that repro and a normal two-hook sequence.
Written by the indexing model from the issue text.
Description
scripts/review-hook.sh at b96823b73697d1ff09fa11bf63b85b6cebe71c8d acquires $RUNNER_TEMP/injected-deliveries.lock with mkdir and waits forever. The EXIT trap removes it on a normal exit, but a hook killed by a timeout, SIGTERM, OOM, or sandbox cancellation leaves the directory behind. Every later hook then spins in until mkdir ...; do sleep 0.01; done, so the review stops receiving activity and blocks until its deadline.
Repro: create $RUNNER_TEMP/injected-deliveries.lock, then run timeout 1 bash scripts/review-hook.sh with a Stop payload; it exits 124 and produces no output. A hook killed after acquiring the lock leaves the same state.
A bounded wait with stale-lock recovery (owner PID/age or a lock released on process death) would avoid the permanent block while keeping delivery serialized.
Seen while pinning the hosted runner in promplate/platform 1658c905fa367e301a1748109f327feba08322ed.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 6h
- Merged PRs (30d)
- 118
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from promplate/code-review
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
promplate/code-review#131 · 1 comment ·
Maintainers usually reply within 1 day
All issues in promplate/code-review
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Update project links after the repository renamesPossibly taken @JonathanTSilva claimed this today. Openai-generated priority: p2 size: xs type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
JonathanTSilva/jts-website#119 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
[Docs] CONTRIBUTING points the Backend Remake milestone at a branch that does not existPossibly taken @franpts2 claimed this today. Opendocs
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day