react 19: the Dependabot halves cannot resolve alone, so the bump needs one combined PR

Aberta Para iniciantes
#403 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 4 dias

@IanoNjuguna já está trabalhando nisso.

Desde 22/11/2026.

  • #404 de @IanoNjuguna — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
70/100
Tipo de issue
Refatoração
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github-actions, react, typescript

Direção de pesquisa

Comece em website/package.json, depois confira website/package-lock.json e .github/workflows/deploy.yml; as duas metades falhas do Dependabot são #401/#402 e explicam por que um lockfile não mesclado quebra o deploy do Pages. Em website, atualize react, react-dom e @types/react-dom, regenere o lockfile com npm install e depois verifique com npm ci e npm run build. Está concluído quando o PR combinado instala sem erros e o build passa; a limpeza de packageManager/resolutions do yarn, que ficou obsoleta, fica para uma mudança separada.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

dependencies

Dependabot opened the react 19 major as two PRs, and neither can pass on its own:

  • #401 bumps react 18.3.1 to 19.3.1
  • #402 bumps react-dom and @types/react-dom to 19.3.1 / 19.3.0

Each half breaks the other's peer requirement, so both fail npm ci with ERESOLVE:

#402: Found: [email protected]
      Could not resolve dependency: peer react@^19.3.1 from [email protected]

#401: Found: [email protected]
      Could not resolve dependency: peer react-dom@^18.3.1 from [email protected]

Merging them one after the other does not fix it either. deploy.yml runs on every push to main, so between the two merges the tracked lockfile does not resolve, the build job fails, and the Pages deploy is skipped. Any PR opened in that window inherits the same broken lockfile.

Proposed fix

One PR that takes the peer set together, with a regenerated lockfile:

  • react and react-dom to ^19.3.1
  • @types/react-dom to ^19.3.0 (19.3.1 does not exist)

Verified locally against main at 973801b:

  • npm install with the bumped versions: 1409 packages, no ERESOLVE
  • npm ci against the regenerated website/package-lock.json: exit 0
  • npm run build: SUCCESS, static files generated

@docusaurus/core 3.10.2 declares react ^18.0.0 || ^19.0.0, so 19 is inside the supported range. The @slorber/react-helmet-async alias it depends on prints a peer warning capped at react 18, and the install still exits 0.

Related, separate

website/package.json still carries packageManager: [email protected] and a resolutions block pinning react and react-dom to ^18.3.1, both stale since the repo standardised on npm. A yarn install would put react 18 back. npm ignores both, so this does not block the bump, but it should be cleaned up in its own change.

Also worth considering: a groups entry in .github/dependabot.yml covering the peer set, so the next react major arrives as one PR instead of two unresolvable halves.

Linguagem predominante
TypeScript
Estrelas
13
Forks
24
Merge médio
2d 3h
PRs com merge (30d)
16

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de IntersectMBO/developer-experience

Todas as issues de IntersectMBO/developer-experience

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.