Move Transaction.Internal.Common helpers into focused modules
Maintainers usually reply within 1 day
@Jimbo4350 is already working on this.
Since Oct 13, 2026.
Assessment
This issue has not been assessed yet.
Description
Transaction.Internal.Common groups unrelated helpers for output conversion, mint validation, signing witnesses, and reference inputs. Give each helper a more specific home while preserving sharing between the transaction and sub-transaction builders without import cycles.
Suggested moves from the review:
toTxOutInEra→ a newTransaction.Internal.TxOutmodule.getAllReferenceInputs→ a newTransaction.Internal.ReferenceInputmodule.createTxMintValue→Script.Mint.Read.convertVotingProcedures→Script.Vote.Read.scriptInEraToSimpleScript→Script.Read.Common.partitionSomeWitnesses→Cardano.CLI.Read, alongsideByronOrShelleyWitness, removing the transaction-internal dependency fromCompatible.Transaction.Run.- Return
toTxOutInShelleyBasedErato its sole caller's module,Transaction.Run. - Replace the
convertWithdrawalswrapper withExp.TxWithdrawalsat its call sites.
Update imports and module declarations, remove the common module if no longer needed, and preserve existing CLI behavior and tests.
Deferred from PR #1453: review comment. Jordan marked this non-critical and suitable for a future PR.
- Dominant language
- Haskell
- Stars
- 72
- Forks
- 25
- Avg merge
- 3d
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from IntersectMBO/cardano-cli
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
IntersectMBO/cardano-cli#1306 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 56/100
IntersectMBO/cardano-cli#1472 ·
Maintainers usually reply within 1 day
-
Clarify the origin and intended use of Plutus V2/V4 test fixturesPossibly taken @Jimbo4350 claimed this 3 days ago. Open
IntersectMBO/cardano-cli#1464 · 1 assignee ·
Maintainers usually reply within 1 day
-
Share body construction and input reading between transaction and sub-transaction buildersPossibly taken @Jimbo4350 claimed this 3 days ago. Openrefactor
IntersectMBO/cardano-cli#1463 · 1 assignee ·
Maintainers usually reply within 1 day
-
Share common transaction-body arguments across builder commandsPossibly taken @Jimbo4350 claimed this 3 days ago. Openrefactor
IntersectMBO/cardano-cli#1462 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in IntersectMBO/cardano-cli
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
ndmitchell/hlint#1710 ·
-
CJK text is italicizedPossibly taken @daniel-gregg claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 4 days
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
simplex-chat/simplex-chat#7714 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days