freestanding-check: six clang warnings for view locals left uninitialised (const member)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- c
- Domain
- build-system, testing
Research direction
Start with the listed EigsView declarations in src/builtins_int.c, src/ext_http.c, and src/trace.c, then run make freestanding-check to see which clang rows compile them. Initialize each affected local at its declaration or determine whether the view type can avoid the const-member warning. Done when the clang rows print no -Wdefault-const-init-field-unsafe warning and the gcc rows and symbol counts remain unchanged.
Written by the indexing model from the issue text.
Description
make freestanding-check on the long branch (phase2-numbers) prints six warning lines of one kind in its clang rows (the zig and riscv compilers; gcc prints none):
src/builtins_int.c:105:14: warning: default initialization of an object of type 'EigsView' with const member leaves the object uninitialized [-Wdefault-const-init-field-unsafe]
105 | EigsView av, bv;
The gate passes: it counts symbols, not warnings. The lines are noise in a log that is read for real warnings, and the same declaration shape is at seven more places that the freestanding rows do not compile (src/builtins_int.c, src/ext_http.c, src/trace.c: git grep -n 'EigsView [a-z, ]*;' src).
The other 167 warning lines of that log are -Watomic-alignment on the 32-bit RISC-V row, which #1984 decided; they are not this issue.
Done when
- The clang rows of
make freestanding-checkprint no-Wdefault-const-init-field-unsafeline (each such local is initialised where it is declared, or the view type no longer needs it). - The gcc rows and the gate's symbol counts are unchanged.
Found by a builder of #2452 in its hand run of the gate (out of that change's scope).
— Claude DevBox
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 3h 28m
- Merged PRs (30d)
- 270
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
InauguralSystems/EigenScript#2476 ·
Maintainers usually reply within 1 day
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameOpenarea:gates kind:gate-defect needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
InauguralSystems/EigenScript#2461 · 1 comment ·
Maintainers usually reply within 1 day
-
area:gates kind:gate-defect needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
InauguralSystems/EigenScript#2458 · 1 comment ·
Maintainers usually reply within 1 day
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordOpenarea:http kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
InauguralSystems/EigenScript#2394 · 1 comment ·
Maintainers usually reply within 1 day
-
area:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
InauguralSystems/EigenScript#2360 ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
flipperdevices/flipperzero-firmware#4520 ·
Maintainers usually reply within 1 day
-
area/build-framework kind/enhancement priority/low
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
yugabyte/yugabyte-db#38826 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
meshcore-dev/MeshCore#3891 · 1 comment ·
Maintainers usually reply within 1 day
-
bug grammar sev-3
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
BUG/MEDIUM: regex: worker SIGSEGV when a regex is applied to an empty body on libc-regex buildsOpenstatus: needs-triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100