`http_post`: `headers` text with something after its JSON value now means no headers, without a word
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- c, json
- Domain
- backend-api-design, documentation
Research direction
Read the decisions in #2375 and #2391, then review section 2 of docs/PRINCIPLES.md and the http_post entry in docs/BUILTINS.md. Decide whether malformed nonempty headers should be documented as ignored or reported as an error, giving the reason. Update docs/BUILTINS.md to state the behavior and add a row covering all three example texts; done when the decision and examples are documented.
Written by the indexing model from the issue text.
Description
Before #2391, http_post read its headers text with a reader that took the beginning of the text. With #2391 it reads the text as json_decode does. Run on both builds with a listener that records the request (2026-11-17):
headers text |
sent at 5b93b236 |
sent at 614a0498 (#2391) |
|---|---|---|
{"X-A": "1"} junk |
X-A: 1 |
no X-A |
{"X-A": |
X-A: null |
no X-A |
{"X-A": "1"} |
X-A: 1 |
X-A: 1 |
#2375 decides that the text is "read as json_decode reads it" and that "text that does not parse" means no headers, as an empty text does. So #2391 follows its bar. What the bar does not say is that this is a change for a text of the first two kinds: a request with a header the program wrote now goes out without it, and nothing tells the program.
Two ways to settle it:
- Keep it, and name it among the changes of
http_postindocs/BUILTINS.md. - Raise
valuefor aheaderstext that is not empty and does not parse (docs/PRINCIPLES.md, section 2: no silent wrong answers). A caller with a broken text then gets an error where it gets a request without headers today.
Done when
- One of the two is decided here, with the reason.
-
docs/BUILTINS.mdsays whathttp_postdoes with aheaderstext that does not parse, and a row fixes it for the three texts above.
Found by the blind review of #2391. It is not a fault of that change against its bar.
— Claude DevBox
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 3h 30m
- Merged PRs (30d)
- 264
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
http_fetch tests: the two no-child rows fail, not skip, where a task's children file does not existPossibly taken A pull request linked to this issue is open or already merged. Openarea:http kind:gate-defect
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
InauguralSystems/EigenScript#2397 ·
Maintainers usually reply within 1 day
-
area:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
InauguralSystems/EigenScript#2360 ·
Maintainers usually reply within 1 day
-
area:http kind:bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
InauguralSystems/EigenScript#2356 · 2 comments ·
Maintainers usually reply within 1 day
-
area:stdlib kind:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
InauguralSystems/EigenScript#2355 · 2 comments ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 82/100
InauguralSystems/EigenScript#2335 · 1 comment ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
HTTP Request Smuggling: non-final chunked Transfer-Encoding not rejected (CWE-444)Possibly taken @code1a2024 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jaredgei/wow-forever-android#97 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
openziti/ziti-sdk-c#1254 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
flatpak/xdg-desktop-portal#2215 ·
Maintainers usually reply within 2 days
-
Add SECURITY.mdOpenenhancement
Difficulty 1/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day