The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its name

Open Beginner friendly
#2,461 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bash, c, git
Domain
testing, tooling

Research direction

Read tools/freestanding_check.sh and tests/test_freestanding_rng_2308.sh first. The issue identifies the filename listing and the test that should cover it; check how the script reads the list, then run the test. Done means the quoted-name case passes, the tracked source that calls rand fails with its name, and all 40 existing cases still pass.

Written by the indexing model from the issue text.

Description

area:gates kind:gate-defect needs-triage

tools/freestanding_check.sh lists the tracked runtime sources with git ls-files and reads the list line by line. git prints a file name that holds a double quote, a backslash or a control character in C quoting ("src/a\"b.c"), whatever core.quotePath says, so the tool then looks for a file of that quoted name and stops:

FAIL: hosted RNG check cannot read the tracked file "src/a\"b.c"

for a clean tracked src/a"b.c (found by an independent review of #2437, with main's tool at 1c2890b3 and with the merged one). It fails closed: nothing is missed, a clean tree is refused. The tree has no such file today.

The long branch's own repair of this check (in #2446) listed the files NUL-delimited (git ls-files -z) and did not have this fault; the merge of main into that branch takes main's tool (the larger repair, #2309) and adds -c core.quotePath=false for non-ASCII names only.

Done when

  • The tool lists its population NUL-delimited, and a case of tests/test_freestanding_rng_2308.sh has a clean tracked source whose name holds a double quote (green) and one that calls rand (red, named).
  • The 40 cases the test has after the merge still pass.

— Claude DevBox

Dominant language
C
Stars
3
Forks
7
Avg merge
3h 28m
Merged PRs (30d)
270

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from InauguralSystems/EigenScript

All issues in InauguralSystems/EigenScript

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.