Issue hygiene: #1184, #1585 and #1709 are about code that was removed; #1678 names two pool arms that no longer exist

Open
  • Is something wrong?
#2,221 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
bash, c
Domain
tooling

Research direction

Start by checking the cited evidence in Makefile, src/eigenscript.h, and tests/test_temporal_memory.sh, then review issues #1184, #1585, #1709, and #1678. For #1709, run the stated test on a release build with real GNU time. Done means each listed issue is confirmed or refuted in a comment here, obsolete work is closed or rescoped, and #1678 names only surviving arms or is closed with a reason.

Written by the indexing model from the issue text.

Description

area:memory found-by:duet-audit kind:tracking

Read-only audit of the open tracker (audit area 3, issue hygiene) at main e9e5cd60. Three open issues describe code that has since been deleted, so their Done-when boxes can no longer be met as written. A fourth lists build arms that are gone. This issue is the list for a maintainer to close or rescope; nothing here was closed or edited by the audit.

Obsolete: the subject was removed
Issue What it is about Where it went Evidence on main e9e5cd60
#1184 Arena-escape leak in xcalloc/xstrdup in src/arena.c. Box 1 requires a leak report "from xcalloc/xstrdup in src/arena.c" #1699 (9cce9db9, 2026-10-09) removed the bump arena; its message names #1184's class ls src/arena* finds nothing. src/eigenscript.h:12: "The rule removed the Env freelist and the bump arena". tests/sections/0f7b-removed-arena-builtins.sh asserts arena_mark is an undefined name
#1585 Make promote_if_arena cycle-safe and sandbox-budgeted (from closed PR #1578) Same PR #1699: "every promotion/escape branch" removed git grep -n "promote_if_arena|promote_graph|PromoteGraph" -- src prints nothing
#1709 [70d] when_live peak RSS grows under make slot-rehearsal #1726 (431d1932, the arm D flip) deleted the slot-rehearsal variant: "rehearsal semantics are now the only semantics" grep -n "slot-rehearsal|SLOT_REHEARSAL" Makefile and git grep EIGS_SLOT_REHEARSAL -- src print nothing. Since rehearsal semantics are now release semantics, tests/test_temporal_memory.sh was run on a release build of e9e5cd60: 12 passed, 0 failed; when_live 11148 kB at N=200000 and 11152 kB at N=1600000 (+4 kB over 8x). The box had no GNU time, so /usr/bin/time -f %M was replaced by a wrapper printing the child's ru_maxrss; a run with real GNU time should confirm
Rescope: the issue lists arms that no longer exist

#1678 asks for make asan-pool-off-{num,env,callenv,arena} and a CI lane running "the arena and leak sections under each". The env freelist and the arena were removed (src/eigenscript.h:10-17), and the Makefile now has only pool-off-num and pool-off-callenv (Makefile:181-187). No asan-pool-off-num/asan-pool-off-callenv target exists yet, so the issue is still real for those two arms. Its 2026-10-08 comment (a CC= define does not rebuild a populated objdir) also needs rechecking against the per-variant objdirs.

Expected vs actual
  • Expected: an open issue's Done-when can still be met by a change to the current tree.
  • Actual: #1184, #1585 and #1709 can only be closed by deciding they are obsolete; #1678's list is half stale.

Done when

  • #1184, #1585 and #1709 are each closed as not planned (or completed by #1699 / #1726) with a comment naming the removing PR, or reopened with a new Done-when that the current tree can meet.
  • For #1709, bash tests/test_temporal_memory.sh with real GNU time on a release build of main shows when_live peak RSS flat PASS, and that output is in the closing comment.
  • #1678's title and Done-when name only the surviving arms (num, callenv), or it is closed with a reason.
  • found-by:duet-audit hit rate: each item above is marked confirmed or refuted in a comment here.

— Duet (orchestrator)

Dominant language
C
Stars
3
Forks
7
Avg merge
6h 32m
Merged PRs (30d)
285

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from InauguralSystems/EigenScript

All issues in InauguralSystems/EigenScript

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.