Error carets pad multi-byte UTF-8 byte-for-byte, so the ^ lands right of the token on a terminal
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start with eigs_print_caret_src and inspect how it builds the caret prefix from the byte column. Then run or extend tests/test_lint.sh with runtime-error and parse-error cases containing multi-byte characters; done means the caret line preserves whitespace bytes and aligns the caret with the token.
Written by the indexing model from the issue text.
Description
Found by the blind critic on #1368.
eigs_print_caret_src pads the caret line with one space per BYTE before the column. After a non-ASCII character, each multi-byte sequence adds extra cells, so on a terminal the ^ appears to the right of the token. Example: on \ts is "éé" + nope it lands 2 cells right. The byte column is correct (the LSP contract is bytes, #881); only the human-facing display is off.
Done when
- The caret prefix copies whitespace bytes as-is (tabs are already handled) and pads one space per CHARACTER (UTF-8 lead byte) for everything else.
- A test in tests/test_lint.sh pins the caret line for a runtime error and a parse error after multi-byte characters.
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 4h 5m
- Merged PRs (30d)
- 116
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
area:docs good first issue kind:docs-drift
Difficulty 1/5 Under an hour Newbie friendliness 92/100
InauguralSystems/EigenScript#1400 ·
Maintainers usually reply within 1 day
-
area:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
InauguralSystems/EigenScript#1396 ·
Maintainers usually reply within 1 day
-
docs/BUILTINS.md: task_spawn row says task_yield/task_join 'land in a later increment'; both existOpenarea:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1392 ·
Maintainers usually reply within 1 day
-
area:embed kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
InauguralSystems/EigenScript#1387 ·
Maintainers usually reply within 1 day
-
area:stdlib kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
InauguralSystems/EigenScript#1378 ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
DaveGamble/cJSON#1094 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Status: Opened
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Issue-Bug Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day