ci scope: renaming a C file to *.md classifies the PR as docs-only (code=false)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 86/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- build-system, ci-cd
Research direction
Start with the scope job in .github/workflows/ci.yml and run python3 /tmp/sp-critic/repro_scope.py .github/workflows/ci.yml to reproduce the rename-to-md result. Check how changed paths are collected, then verify that a rename or delete with a non-docs-only old path sets code=true. Add or update the scope self-test with a .c-to-.md fixture and confirm it fails when the fix is reverted.
Written by the indexing model from the issue text.
Description
Found by a blind critic on PR #1310. The same result on main 7706607: this is pre-existing.
The scope job in .github/workflows/ci.yml decides code=true|false from the changed paths. For a rename it sees only the NEW name. git mv src/foo.c notes.md therefore yields code=false, and every code-scoped job (the suite, ASan, the variants) is skipped, although a C source was removed from the build.
Repro: python3 /tmp/sp-critic/repro_scope.py .github/workflows/ci.yml. It builds tiny git histories and runs the real scope step: a code edit gives true, a docs edit gives false, rename-to-md gives false.
Done when:
- a rename or delete whose OLD path is not docs-only yields
code=true(use--name-statusor--no-renames) - a planted fixture (rename
.c→.md) is in the scope step's self-test or CI and goes red with the fix reverted
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 4h 5m
- Merged PRs (30d)
- 116
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
area:docs good first issue kind:docs-drift
Difficulty 1/5 Under an hour Newbie friendliness 92/100
InauguralSystems/EigenScript#1400 ·
Maintainers usually reply within 1 day
-
area:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
InauguralSystems/EigenScript#1396 ·
Maintainers usually reply within 1 day
-
docs/BUILTINS.md: task_spawn row says task_yield/task_join 'land in a later increment'; both existOpenarea:docs good first issue kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1392 ·
Maintainers usually reply within 1 day
-
area:embed kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
InauguralSystems/EigenScript#1387 ·
Maintainers usually reply within 1 day
-
area:stdlib kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
InauguralSystems/EigenScript#1378 ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
DaveGamble/cJSON#1094 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Status: Opened
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Issue-Bug Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day