Small fix: Check if menu entry is not in range or -1

Open
  • Is something wrong?
#267 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
53/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, unity
Domain
frontend, game-dev

Research direction

Start at GUZ.Core.UI.Menus.AbstractMenu.SetText, the entry point named in the issue, and trace how it handles menu indices read from INI values. Check the behavior for _vidResIndex=-1 and other out-of-range values; done means incorrect values no longer crash the main menu.

Written by the indexing model from the issue text.

Description

bug good first issue

If INI values are set incorrect, our main menu crashes.
Please ensure, that e.g.
vidResIndex=-1
won't break.

@see: GUZ.Core.UI.Menus.AbstractMenu.SetText

Dominant language
C#
Stars
33
Forks
1
Avg merge
1d 17h
Merged PRs (30d)
51

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Gothic-Unity-Project/Gothic-Unity

All issues in Gothic-Unity-Project/Gothic-Unity

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.