Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

fix(core): propagate archive extraction and copy failures

Open
  • Is something wrong?
#5,048 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
bash, shell
Domain
devtools

Research direction

Start with fn_dl_extract in lgsm/modules/core_dl.sh and trace the branch taken for an unsupported MIME type, where the function can return success without extracting anything. Then look at the selective ZIP path (extractsrc set): unzip, cp, then rm, where the final status must reflect a failed copy even if cleanup succeeds. Done means explicit errors with non-zero exit through the installer/update path, including exitbypass handling, with the listed validation cases reproduced.

Written by the indexing model from the issue text.

Description

type: bug

Problem

fn_dl_extract in lgsm/modules/core_dl.sh can report successful extraction after an error, or without extracting anything.

This is the remaining extraction concern raised in #2421. The original curl-download error handling is now present and has been checked separately.

Paths to address

  • An unsupported MIME type matches none of the extraction branches. The surrounding conditional can return success, allowing the function to print an extraction success message without extracting any files.
  • In the selective ZIP extraction path (extractsrc set), the function runs unzip, then cp, then rm. The final status can reflect successful cleanup rather than a failed extraction or copy.

Expected behaviour

Unsupported archive types and failed extraction/copy operations must produce a clear error, terminate the installation/update with a non-zero exit status, and prevent later steps from reporting success. Cleanup must preserve the original failure status.

Validation

  • Unsupported archive format fails explicitly.
  • Corrupt/truncated supported archives fail.
  • Selective ZIP extraction fails when the requested source is absent or extraction fails.
  • Copy failures in selective ZIP extraction fail even when cleanup succeeds.
  • Successful full and selective extraction still work.
  • Verify failure propagation through a calling installer/update path, including any use of exitbypass.

These findings come from reviewing the current develop implementation; the extraction failure cases still require reproduction and regression checks.

Dominant language
Shell
Stars
4.9k
Forks
870
Avg merge
1d 5h
Merged PRs (30d)
68

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GameServerManagers/LinuxGSM

All issues in GameServerManagers/LinuxGSM

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.