feat(core): report a clear error when the configured branch doesn't exist
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
Research direction
The branch is read from githubbranch or LGSM_GITHUBBRANCH, and bootstrap and update-lgsm are the places the check would run; the payload names no specific files, so locate the download helpers by searching for the GitHub fallback logic. Done means one branch-existence check per run that fails with the requested message on a 404 only, while timeouts, 429 and 5xx keep the existing fallback. Confirm the design with maintainers before writing code, since the issue reads as a proposal rather than a settled fix.
Written by the indexing model from the issue text.
Description
Problem
If the configured branch (githubbranch, or LGSM_GITHUBBRANCH) doesn't exist on githubuser/githubrepo, for example after a typo or once a feature branch has been deleted after merging, LinuxGSM's module downloads fail with generic download errors. The real cause isn't reported.
Proposal
Check once, during bootstrap and in update-lgsm, that the branch exists, and fail with a clear message if it doesn't:
Branch "<branch>" not found on <githubuser>/<githubrepo>
- Check once per run, not on every file download.
- Use a connect timeout, like the existing repo selection (
--connect-timeout 3). - Treat only a 404 as "branch missing". Other errors (timeouts, 429, 5xx) should keep the current GitHub/Bitbucket fallback.
- Fail clearly rather than silently switching to
master, so nobody ends up on code they didn't choose.
Replaces the draft #4170 (closed): it had bugs, including a sed -i ...;q in update-lgsm that would have cut the game server script down to one line, and it was 486 commits behind develop.
- Dominant language
- Shell
- Stars
- 4.9k
- Forks
- 870
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 45
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GameServerManagers/LinuxGSM
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
GameServerManagers/LinuxGSM#4956 ·
Maintainers usually reply within 1 day
-
[iosserver] IOSoccer moved to a 64-bit server, srcds_run no longer existsPossibly taken A pull request linked to this issue is open or already merged. Openengine: source game: IOSoccer info: dependency info: query type: bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
GameServerManagers/LinuxGSM#5023 ·
Maintainers usually reply within 1 day
-
command: monitor type: feature
Difficulty 3/5 Half a day Newbie friendliness 42/100
GameServerManagers/LinuxGSM#4995 ·
Maintainers usually reply within 1 day
-
command: console distro: Debian info: website regression: yes reproducible: always severity: medium type: bug
Difficulty 3/5 1-2 days Newbie friendliness 68/100
GameServerManagers/LinuxGSM#4962 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
GameServerManagers/LinuxGSM#4955 ·
Maintainers usually reply within 1 day
All issues in GameServerManagers/LinuxGSM
Similar issues
-
netbox status: backlog topic: testing type: housekeeping
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
netbox-community/netbox#23395 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ajeetdsouza/zoxide#1323 ·
Maintainers usually reply within 1 day
-
e2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
redhat-developer/rhdh-plugin-export-overlays#4391 · 1 comment ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
graygarbage/HermesKey#20 ·