Builder Build panel: redraw the bond-order and geometry icons; a periodic table button
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with ShapeData::shapeToImage and ShapeData::shapeToSmallImage and the bond drop-down code that loads the XPMs from data/client/pixmaps. Check tools/screenshots/icons.py to see how the existing SVGs are rendered for review. The redraw needs SVG versions of the bond and shape icons loaded as wxBitmapBundle, in the Jmol-style ball-and-stick look. The periodic table button is named in the title but not described in the body, so confirm its scope with the maintainers before starting. Done means the toolbar and drop-downs show the new icons at every display scale.
Written by the indexing model from the issue text.
Description
Seen: the Builder toolbar's bond-order chooser (single bond: two grey balls and a line) and geometry chooser (tetrahedral centre) use the original low-resolution bitmaps. They are small, blurry when scaled and drawn in a style the rest of the toolbar no longer has.
Where: the bond icons (bond_single, bond_double, bond_triple, bond_aromatic, bond_metal and their _large forms) and the shape icons (linear, bent, trigonal planar, pyramidal, tetrahedral, square planar, trigonal bipyramidal, square pyramidal, octahedral, in 18/24/48 px) are XPMs in data/client/pixmaps, chosen in ShapeData::shapeToImage/shapeToSmallImage and the bond drop-down.
Proposal: redraw both sets as SVG and load them as wxBitmapBundle (the route the other redrawn icons use; tools/screenshots/icons.py renders them for review), so they are sharp at every display scale. Draw them in the viewer's own ball-and-stick style: shaded spheres, Jmol element colours (carbon centre, grey or white ligands), bond orders as one, two or three sticks, aromatic as a stick with a dashed partner, metal bond dashed. Same set used in the drop-down lists and on the toolbar button.
- Dominant language
- C
- Stars
- 10
- Forks
- 8
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FriendsofECCE/ECCE
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FriendsofECCE/ECCE#336 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
FriendsofECCE/ECCE#339 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
FriendsofECCE/ECCE#338 · 2 comments ·
-
Basis Set Tool: periodic table cut off on the right; elements 110-118 still have placeholder namesOpen
Difficulty 4/5 3-5 days Newbie friendliness 40/100
FriendsofECCE/ECCE#337 ·
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
FriendsofECCE/ECCE#335 ·
All issues in FriendsofECCE/ECCE
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
`inverse()` of a controlled `CUGate` drops the phase parameter γPossibly taken @rupasri118 claimed this today. Openbug mod: circuit
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Qiskit/qiskit#17223 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OpenPrinting/libcupsfilters#284 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
libsdl-org/SDL#16530 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
fw876/helloworld#2067 ·
Maintainers usually reply within 1 day