init --verification-workflow: the generated workflow never installs dependencies, so verify cannot run the tests
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- github-actions, node.js, typescript
Research direction
Start with packages/diffci-cli/src/client/workflow-templates.ts and inspect the diffciVerificationWorkflow template. Reproduce with a project that has vitest in devDependencies and a package-lock.json, then check the generated workflow’s steps. Done means it installs dependencies with npm ci before “Verify changed code” and the test command runs.
Written by the indexing model from the issue text.
Description
diffci init --verification-workflow writes a workflow (diffciVerificationWorkflow in packages/diffci-cli/src/client/workflow-templates.ts) that checks out the repository, sets up Node and runs diffci verify. It never installs the repository's dependencies. verify runs the repository's own tests, so in any project whose test runner is a dev dependency the job fails before a test runs.
Repro: a project with vitest in devDependencies, a package-lock.json and "test": "vitest run". Run diffci init --verification-workflow and run the generated workflow, or run diffci verify in a fresh checkout without npm ci.
Expected: the workflow installs dependencies (npm ci here) before "Verify changed code", and the tests run.
Actual: there is no install step. verify FAILED, and the test command printed "npx canceled due to missing packages" (vitest not installed).
Not covered here: a repository whose package manager DiffCI cannot detect, and Bun.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 4
- Avg merge
- 18h 41m
- Merged PRs (30d)
- 48
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiffCI/core
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at randomPossibly taken @FredApps claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Agent tools: changed_files lists only the new path of a renamed filePossibly taken @FredApps claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
adapter good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
Similar issues
-
agent-ready area: ui-server priority: p3 type: test
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
schlessera/brain-kit#4249 ·
Maintainers usually reply within 1 day
-
documentation tool triaged
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
can1357/oh-my-pi#19608 · 2 comments ·
Maintainers usually reply within 1 day
-
dependencies tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bcgov/nr-waste-plus#1549 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-tx-parse#18 ·