GDA: Axis constraint Scannables naming convention is unintuitive ('You' engine)
@robwalton is already working on this.
Since May 3, 2012.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by tracing how GDA creates axis-constraint Scannables and how physical-axis and hkl scans are handled. Compare the proposed last-value lookup with the grouped-Scannable approach, paying particular attention to avoiding two motor moves. Done means the naming convention is intuitive without causing duplicate moves when an axis is scanned while hkl is held still.
Written by the indexing model from the issue text.
Description
Where an axis (e.g. gamma) may be fixed by a constraint an <axis_name>_con Scannable is created rather than an <axis_name> Scannable in order to avoid a namespace clash with that axis' actual Scannable. This is unintuitive.
One solution is for Diffcalc to read up the last set value for an axis when that axes is constrained.
However if the axis is Scanned while hkl is held still this would result in two motor moves. This could be resolved by making the physical axis Scannables the same level as the hkl Scannable and treating them as a group, although this is a pretty heavy solution.
- Dominant language
- Python
- Stars
- 22
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/diffcalc
-
Profile and optimise Open
Difficulty 5/5 Over a week Newbie friendliness 10/100
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
All issues in DiamondLightSource/diffcalc
Similar issues
-
essnmx good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
[Feature] 奇物选择添加优先级 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
syfoud/Simulated_Scepter#174 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Giskard-AI/giskard-oss#2840 · 1 comment ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Openarea: repo bug perceived difficulty: 2
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
yeti-platform/yeti#1380 ·