Embargo Terms via Metadata doesn't render correctly in UI

Open
  • Is something wrong?
#6,529 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
angular, java, typescript
Domain
frontend, web-dev

Research direction

Start by tracing the Angular UI path that displays the embargo metadata value, using the reproduction settings and the local.embargo.terms example in the issue. Check how the UI handles the value "24 months" and compare it with the expected embargo term. Done when the metadata value is rendered as the corresponding embargo term; the issue does not identify a UI file or test.

Written by the indexing model from the issue text.

Description

bug needs triage

Describe the bug

A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public.

To Reproduce

Steps to reproduce the behavior:
Enable embargo using dspace-api/src/main/java/org/dspace/embargo/DayTableEmbargoSetter.java function
2. Set the following values

embargo.terms.days = 3 months:90,6 months:183,12 months:365,18 months:548,24 months:730,30 months:913,36 months:1095,42 months:1278,48 months:1461
embargo.terms.open = forever-do-not-use-me
embargo.field.terms = local.embargo.terms
embargo.field.lift = local.embargo.lift
  1. Try one of the values like "24 months"
    You see something like
image 
        "local.embargo.terms" : [ {
          "value" : "24 months",
          "language" : null,
          "authority" : null,
          "confidence" : -1,
          "place" : 0
        } ],

This is the metadata value that goes into that field

Expected behavior

Embargo date to be converted to the term specified in the metadata from the string.

Documentation

Dominant language
TypeScript
Stars
180
Forks
577
Avg merge
1d 23h
Merged PRs (30d)
95

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DSpace/dspace-angular

All issues in DSpace/dspace-angular

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.